Conversation
|
@donramanauskas @lukaspour can one of you check this PR. |
donramanauskas
left a comment
There was a problem hiding this comment.
There are some teams that use this scanner and they have terraform that's older than 0.14 in their environment. I don't see a reason for this >=0.14 requirement. If you remove version upgrade I could approve the part with Taskfile checks and Github Action.
|
@donramanauskas which version are they using, i need to specify which version to be used in testing. |
Since the Action workflow and the Taskfile are only related to Github testing the code, and since, there is no minimum requirement in the Terraform configuration about minimum version, then teams using Terraform lower than 0.14 should still be able to use it. I think it is beneficial for automated tests to specify a version, since it ensures that the tests will not break new PRs if a new version is released. It will give more test consistency. @donramanauskas Would you agree? |
No description provided.