Skip to content

Added testing#3

Open
SadriG91 wants to merge 4 commits intotelia-oss:masterfrom
SadriG91:master
Open

Added testing#3
SadriG91 wants to merge 4 commits intotelia-oss:masterfrom
SadriG91:master

Conversation

@SadriG91
Copy link

No description provided.

@SadriG91
Copy link
Author

@donramanauskas @lukaspour can one of you check this PR.
Thank you!

Copy link
Contributor

@donramanauskas donramanauskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some teams that use this scanner and they have terraform that's older than 0.14 in their environment. I don't see a reason for this >=0.14 requirement. If you remove version upgrade I could approve the part with Taskfile checks and Github Action.

@SadriG91
Copy link
Author

SadriG91 commented May 12, 2021

@donramanauskas which version are they using, i need to specify which version to be used in testing.

@SadriG91 SadriG91 requested a review from donramanauskas May 12, 2021 06:53
@SadriG91 SadriG91 changed the title Upgraded to Terraform 0.14 and added testing Added testing May 17, 2021
@SadriG91 SadriG91 requested a review from larstobi May 18, 2021 07:26
@larstobi
Copy link

larstobi commented Dec 5, 2022

There are some teams that use this scanner and they have terraform that's older than 0.14 in their environment. I don't see a reason for this >=0.14 requirement. If you remove version upgrade I could approve the part with Taskfile checks and Github Action.

Since the Action workflow and the Taskfile are only related to Github testing the code, and since, there is no minimum requirement in the Terraform configuration about minimum version, then teams using Terraform lower than 0.14 should still be able to use it.

I think it is beneficial for automated tests to specify a version, since it ensures that the tests will not break new PRs if a new version is released. It will give more test consistency.

@donramanauskas Would you agree?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants