Skip to content

Fix type definitions for express Request & Response #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dmaretskyi wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix type definitions for express Request & Response #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d6baa3f
Fix exporess type defenitions
dmaretskyi Dec 19, 2019
42dfc41
Add configurable request finish log message
dmaretskyi Dec 19, 2019
ad9633a
Fix
dmaretskyi Dec 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,19 +19,22 @@ declare namespace bunyanMiddleware {
verbose?: boolean
level?: 'trace' | 'debug' | 'info' | 'warn' | 'error' | 'fatal'
filter?: { (req: Request, res: Response): boolean }
finishMessage?: (req: Request, res: Response) => string
}
export interface ParamsWithLogger extends Params {
logger: Logger
}
}


declare module 'express' {
export interface Request {
log: Logger
reqId: string
}
export interface Response {
log: Logger
declare global {
namespace Express {
export interface Request {
log: Logger
reqId: string
}
export interface Response {
log: Logger
}
}
}
3 changes: 2 additions & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ module.exports = function (options, logger) {
, filter = options.filter
, parentRequestSerializer = logger.serializers && logger.serializers.req
, level = options.level || 'info'
, finishMessage = options.finishMessage || (() => 'request finish')

function processHeaderNames(property) {
if (property && property.length) {
Expand Down Expand Up @@ -116,7 +117,7 @@ module.exports = function (options, logger) {
})
}
}
res.log[level](reqFinishData, 'request finish')
res.log[level](reqFinishData, finishMessage(req, res))
})

next()
Expand Down