Fix for GetTableRows query with sha256 index#47
Merged
Conversation
Author
|
As discussed with Jesse this behaivour was there to accomodate work on SnarkTor which relies on the RSDK which has this wrong indexing on sha256 |
guilledk
force-pushed
the
sha256_index_fix
branch
from
c485ff3 to
899e57b
Compare
guilledk
force-pushed
the
sha256_index_fix
branch
from
899e57b to
c1ebf79
Compare
ptagl
approved these changes
Feb 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem found during writing a
get_account_row_by_addrhelper function in reth, the.to_index()function is not appropriate looking at the final json.