Skip to content

ArrowArrayBuilder protocol work. Re-organise IPC related in anticipation of factoring into separate module. #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
willtemperley merged 7 commits into from
Nov 1, 2025
Merged

ArrowArrayBuilder protocol work. Re-organise IPC related in anticipation of factoring into separate module. #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
77dda93
AsString merged into AnyArrowArray
willtemperley Oct 31, 2025
8f676e2
Merge branch 'main' of https://github.com/willtemperley/swift-arrow
willtemperley Oct 31, 2025
e60219f
Gather FlatBuffers utilities into one place.
willtemperley Oct 31, 2025
4c4e54b
Rename ArrowArrayHolderBuilder to reflect change from ArrowArrayHolde…
willtemperley Nov 1, 2025
d98aaf9
Clearly name the type parameters on ArrowArrayBuilder.
willtemperley Nov 1, 2025
604a822
Introduce ArrowArrayBuilderProtocol which will become the ArrowArray…
willtemperley Nov 1, 2025
ee6e143
Migrate most ArrowArrayBuilder functions to protocol extensions.
willtemperley Nov 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions Sources/Arrow/ArrowArray.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,13 @@ public protocol AnyArrowArray {
var bufferData: [Data] { get }
var bufferDataSizes: [Int] { get }
func asAny(_ index: UInt) -> Any?
func asString(_ index: UInt) -> String
}

// MARK: - Core Protocol

/// The interface for Arrow array types.
public protocol ArrowArray<ItemType>: AsString, AnyArrowArray {
public protocol ArrowArray<ItemType>: AnyArrowArray {
associatedtype ItemType
var arrowData: ArrowData { get }
init(_ arrowData: ArrowData) throws(ArrowError)
Expand All @@ -38,7 +39,6 @@ public protocol ArrowArray<ItemType>: AsString, AnyArrowArray {

// MARK: - Default Implementations
extension ArrowArray {

public var nullCount: UInt {
arrowData.nullCount
}
Expand Down Expand Up @@ -188,8 +188,7 @@ public struct Date32Array: ArrowArray {
let byteOffset = self.arrowData.stride * Int(index)
let milliseconds = self.arrowData.buffers[1].rawPointer.advanced(
by: byteOffset
).load(
as: UInt32.self)
).load(as: UInt32.self)
return Date(timeIntervalSince1970: TimeInterval(milliseconds * 86400))
}
}
Expand All @@ -209,8 +208,7 @@ public struct Date64Array: ArrowArray {
let byteOffset = self.arrowData.stride * Int(index)
let milliseconds = self.arrowData.buffers[1].rawPointer.advanced(
by: byteOffset
).load(
as: UInt64.self)
).load(as: UInt64.self)
return Date(timeIntervalSince1970: TimeInterval(milliseconds / 1000))
}
}
Expand Down Expand Up @@ -451,7 +449,7 @@ public struct NestedArray: ArrowArray, AnyArrowArray {
switch item {
case nil:
output.append("null")
case let asStringItem as AsString:
case let asStringItem as AnyArrowArray:
output.append(asStringItem.asString(0))
case let someItem?:
output.append("\(someItem)")
Expand All @@ -466,7 +464,7 @@ public struct NestedArray: ArrowArray, AnyArrowArray {
var output = "{"
if let children = self.children {
let parts = children.compactMap { child in
(child as? AsString)?.asString(index)
child.asString(index)
}
output.append(parts.joined(separator: ","))
}
Expand Down
Loading