refactor(vite-plugin): fix redirect handling and improve error messages (#1782)

Author: xHeaven

packages/vite-plugin-tempest/src/config.ts

@@ -52,7 +52,11 @@ async function loadConfigurationFromTempestConsole(): Promise<TempestViteConfigu
 		const { stdout } = await exec(`${php.value} ${TEMPEST_BIN} ${VITE_CONFIG_COMMAND}`)
 		const json = stdout.match(/\{.*\}/s)
 
-		return JSON.parse(json?.[0] as string)
+		if (!json?.[0]) {
+			throw new Error('Could not find valid JSON in Tempest console output')
+		}
+
+		return JSON.parse(json[0])
 	} catch (error) {
 		console.error(
 			`[vite-plugin-tempest] Could not load configuration from [${php.value} ${TEMPEST_BIN} ${VITE_CONFIG_COMMAND}].`,

packages/vite-plugin-tempest/src/plugin.ts

@@ -193,6 +193,7 @@ export default function tempest(): Plugin {
 					if (req.url === '/index.html') {
 						res.writeHead(302, { Location: appUrl })
 						res.end()
+						return
 					}
 
 					next()
@@ -325,10 +326,6 @@ function resolveEnvironmentServerConfig(env: Record<string, string>): {
  * Resolve the host name from the environment.
  */
 function resolveHostFromEnv(env: Record<string, string>): string | undefined {
-	if (env.VITE_DEV_SERVER_KEY) {
-		return env.VITE_DEV_SERVER_KEY
-	}
-
 	try {
 		return new URL(env.BASE_URI).host
 	} catch {

packages/vite/src/PrefetchConfig.php

@@ -13,7 +13,7 @@ public function __construct(
         public PrefetchStrategy $strategy = PrefetchStrategy::NONE,
 
         /**
-         * Number of assets to prefech concurrently when using the waterfall strategy.
+         * Number of assets to prefetch concurrently when using the waterfall strategy.
          */
         public int $concurrent = 3,