refactor(validation): add type guards and Unicode support across rules (#1780)

Author: xHeaven

packages/validation/src/Rules/DoesNotEndWith.php

@@ -20,6 +20,10 @@ public function __construct(
 
     public function isValid(mixed $value): bool
     {
+        if (! is_string($value)) {
+            return false;
+        }
+
         return ! str_ends_with($value, $this->needle);
     }
 

packages/validation/src/Rules/DoesNotStartWith.php

@@ -20,6 +20,10 @@ public function __construct(
 
     public function isValid(mixed $value): bool
     {
+        if (! is_string($value)) {
+            return false;
+        }
+
         return ! str_starts_with($value, $this->needle);
     }
 

packages/validation/src/Rules/EndsWith.php

@@ -20,6 +20,10 @@ public function __construct(
 
     public function isValid(mixed $value): bool
     {
+        if (! is_string($value)) {
+            return false;
+        }
+
         return str_ends_with($value, $this->needle);
     }
 

packages/validation/src/Rules/HasCount.php

@@ -26,6 +26,10 @@ public function __construct(
 
     public function isValid(mixed $value): bool
     {
+        if (! is_array($value) && ! $value instanceof \Countable) {
+            return false;
+        }
+
         $length = count($value);
 
         $min = $this->min ?? $length;

packages/validation/src/Rules/HasLength.php

@@ -30,7 +30,7 @@ public function isValid(mixed $value): bool
             return false;
         }
 
-        $length = strlen($value);
+        $length = mb_strlen($value);
 
         $min = $this->min ?? $length;
         $max = $this->max ?? $length;

packages/validation/src/Rules/IsBetween.php

@@ -21,6 +21,10 @@ public function __construct(
 
     public function isValid(mixed $value): bool
     {
+        if (! is_numeric($value)) {
+            return false;
+        }
+
         return $value >= $this->min && $value <= $this->max;
     }
 

packages/validation/src/Rules/IsDivisibleBy.php

@@ -20,11 +20,13 @@ public function __construct(
 
     public function isValid(mixed $value): bool
     {
-        if (! is_numeric($value) || $value === 0) {
+        if (! is_numeric($value)) {
             return false;
         }
 
-        return new IsMultipleOf($this->divisor)->isValid($value);
+        $intValue = (int) $value;
+
+        return ($intValue % $this->divisor) === 0;
     }
 
     public function getTranslationVariables(): array

packages/validation/src/Rules/IsEnum.php

@@ -62,6 +62,8 @@ enum: $this->enum,
                 ...$this->only,
                 ...(is_array($values) ? $values : func_get_args()),
             ],
+            except: $this->except,
+            orNull: $this->orNull,
         );
     }
 

packages/validation/src/Rules/IsJsonString.php

@@ -20,6 +20,10 @@ public function __construct(
 
     public function isValid(mixed $value): bool
     {
+        if (! is_string($value)) {
+            return false;
+        }
+
         $arguments = ['json' => $value];
 
         if ($this->depth !== null) {

packages/validation/src/Rules/IsLowercase.php

@@ -15,6 +15,10 @@
 {
     public function isValid(mixed $value): bool
     {
+        if (! is_string($value)) {
+            return false;
+        }
+
         return $value === mb_strtolower($value);
     }
 }