fix(database): support insertion of relations using create on models

Author: innocenzi

packages/database/src/Builder/ModelQueryBuilder.php

@@ -241,7 +241,6 @@ public function create(mixed ...$params): object
 
         $id = query($this->model)
             ->insert($model)
-            ->build()
             ->execute();
 
         $inspector = inspect($this->model);

packages/database/src/Builder/QueryBuilders/InsertQueryBuilder.php

@@ -393,12 +393,26 @@ private function resolveObjectData(object $model): array
                 continue;
             }
 
-            if ($definition->getHasMany($property->getName()) || $definition->getHasOne($property->getName())) {
+            $propertyName = $property->getName();
+            $value = $property->getValue($model);
+
+            if ($definition->getHasMany($propertyName)) {
+                if (is_iterable($value)) {
+                    $this->addHasManyRelationCallback($propertyName, $value);
+                }
+
                 continue;
             }
 
-            $column = $property->getName();
-            $value = $property->getValue($model);
+            if ($definition->getHasOne($propertyName)) {
+                if (is_object($value) || is_array($value)) {
+                    $this->addHasOneRelationCallback($propertyName, $value);
+                }
+
+                continue;
+            }
+
+            $column = $propertyName;
 
             if ($property->getType()->getName() === PrimaryKey::class && $value === null) {
                 continue;

tests/Integration/Database/Builder/IsDatabaseModelTest.php

@@ -11,6 +11,7 @@
 use Tempest\Database\DatabaseMigration;
 use Tempest\Database\Exceptions\RelationWasMissing;
 use Tempest\Database\Exceptions\ValueWasMissing;
+use Tempest\Database\HasMany;
 use Tempest\Database\HasOne;
 use Tempest\Database\IsDatabaseModel;
 use Tempest\Database\Migrations\CreateMigrationsTable;
@@ -636,6 +637,36 @@ public function test_date_field(): void
         $this->assertSame('2024-01-01 00:00:00', $model->phpDateTime->format('Y-m-d H:i:s'));
         $this->assertSame('2024-01-01 00:00:00', $model->tempestDateTime->format('yyyy-MM-dd HH:mm:ss'));
     }
+
+    public function test_model_create_with_has_many_relations(): void
+    {
+        $this->migrate(
+            CreateMigrationsTable::class,
+            CreateTestUserMigration::class,
+            CreateTestPostMigration::class,
+        );
+
+        $user = TestUser::create(
+            name: 'Jon',
+            posts: [
+                new TestPost('hello', 'world'),
+                new TestPost('foo', 'bar'),
+            ],
+        );
+
+        $this->assertSame('Jon', $user->name);
+        $this->assertInstanceOf(PrimaryKey::class, $user->id);
+
+        $posts = TestPost::select()
+            ->where('testuser_id', $user->id->value)
+            ->all();
+
+        $this->assertCount(2, $posts);
+        $this->assertSame('hello', $posts[0]->title);
+        $this->assertSame('world', $posts[0]->body);
+        $this->assertSame('foo', $posts[1]->title);
+        $this->assertSame('bar', $posts[1]->body);
+    }
 }
 
 final class Foo
@@ -983,3 +1014,66 @@ public function __construct(
         public ?ChildModel $child2 = null,
     ) {}
 }
+
+final class TestUser
+{
+    use IsDatabaseModel;
+
+    public PrimaryKey $id;
+
+    /** @var \Tests\Tempest\Integration\Database\Builder\TestPost[] */
+    #[HasMany]
+    public array $posts = [];
+
+    public function __construct(
+        public string $name,
+    ) {}
+}
+
+final class TestPost
+{
+    use IsDatabaseModel;
+
+    public PrimaryKey $id;
+
+    public function __construct(
+        public string $title,
+        public string $body,
+    ) {}
+}
+
+final class CreateTestUserMigration implements DatabaseMigration
+{
+    public string $name = '010_create_test_users';
+
+    public function up(): QueryStatement
+    {
+        return CreateTableStatement::forModel(TestUser::class)
+            ->primary()
+            ->text('name');
+    }
+
+    public function down(): ?QueryStatement
+    {
+        return null;
+    }
+}
+
+final class CreateTestPostMigration implements DatabaseMigration
+{
+    public string $name = '011_create_test_posts';
+
+    public function up(): QueryStatement
+    {
+        return CreateTableStatement::forModel(TestPost::class)
+            ->primary()
+            ->belongsTo('test_posts.testuser_id', 'test_users.id')
+            ->string('title')
+            ->text('body');
+    }
+
+    public function down(): ?QueryStatement
+    {
+        return null;
+    }
+}