fix(kv-store): correct TTL calculation for expiration

xHeaven · xHeaven · commit b3f09e050660 · 2025-12-03T18:34:17.000+01:00
diff --git a/packages/kv-store/src/Redis/PhpRedisClient.php b/packages/kv-store/src/Redis/PhpRedisClient.php
@@ -99,7 +99,7 @@ public function command(Stringable|string $command, Stringable|string ...$argume
     public function set(Stringable|string $key, mixed $value, null|Duration|DateTimeInterface $expiration = null): void
     {
         if ($expiration instanceof DateTimeInterface) {
-            $expiration = DateTime::now()->since($expiration);
+            $expiration = $expiration->since(DateTime::now());
         }
 
         if ($expiration?->isNegative()) {
diff --git a/packages/kv-store/src/Redis/PredisClient.php b/packages/kv-store/src/Redis/PredisClient.php
@@ -56,7 +56,7 @@ public function command(Stringable|string $command, Stringable|string ...$argume
     public function set(Stringable|string $key, mixed $value, null|Duration|DateTimeInterface $expiration = null): void
     {
         if ($expiration instanceof DateTimeInterface) {
-            $expiration = DateTime::now()->since($expiration);
+            $expiration = $expiration->since(DateTime::now());
         }
 
         if ($expiration?->isNegative()) {

Original file line number	Diff line number	Diff line change
`@@ -99,7 +99,7 @@ public function command(Stringable\|string $command, Stringable\|string ...$argume`
`99`	`99`	`public function set(Stringable\|string $key, mixed $value, null\|Duration\|DateTimeInterface $expiration = null): void`
`100`	`100`	`{`
`101`	`101`	`if ($expiration instanceof DateTimeInterface) {`
`102`		`- $expiration = DateTime::now()->since($expiration);`
	`102`	`+ $expiration = $expiration->since(DateTime::now());`
`103`	`103`	`}`
`104`	`104`
`105`	`105`	`if ($expiration?->isNegative()) {`
Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ public function command(Stringable\|string $command, Stringable\|string ...$argume`
`56`	`56`	`public function set(Stringable\|string $key, mixed $value, null\|Duration\|DateTimeInterface $expiration = null): void`
`57`	`57`	`{`
`58`	`58`	`if ($expiration instanceof DateTimeInterface) {`
`59`		`- $expiration = DateTime::now()->since($expiration);`
	`59`	`+ $expiration = $expiration->since(DateTime::now());`
`60`	`60`	`}`
`61`	`61`
`62`	`62`	`if ($expiration?->isNegative()) {`