feat(router): allow checking an action against the current route#1059
Merged
innocenzi merged 4 commits intotempestphp:mainfrom Mar 25, 2025
Merged
feat(router): allow checking an action against the current route#1059innocenzi merged 4 commits intotempestphp:mainfrom
innocenzi merged 4 commits intotempestphp:mainfrom
Conversation
3bfa653 to
7119cac
Compare
brendt
reviewed
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds the ability to check whether the current route matches the specified controller action:
Note that this doesn't currently apply the regular expression constraint for a given parameter, allowing to match an invalid parameter against the current route (which should never happen, since the route would not have matched in the first place)