refactor(core): move internal storage to project root

[innocenzi]

Closes #1281

Before merging, is .tempest the ideal name? Could also be storage, .internal, or something else. I like a dot directory because it's naturally ignored when scanning the hierarchy, but the name "tempest" is not generic and generally I don't like that

Also, we need to add it to .gitignore in tempestphp/tempest-app

[erikaraujo]

Why not .tempest/internal-storage or .temptest/storage?

[innocenzi]

@erikaraujo That doesn't solve the issue I have with .tempest, and .tempest would be empty besides that "internal" directory 😅

[erikaraujo]

@erikaraujo That doesn't solve the issue I have with .tempest, and .tempest would be empty besides that "internal" directory 😅

@innocenzi The reason I like my suggestion is that it clearly states that it is a framework-specific directory and then it has a more specific "internal" directory inside of it. Or maybe do .tempest/db, .tempest/cache, .tempest/logs... I lack the necessary context of everything that is stored in the internal storage (sorry!)

[innocenzi]

There's already a few subdirectories for each concern, this example is missing local file storage and I believe there may be a few others

I think .tempest might be the most explicit name unfortunately

[aidan-casey]

@innocenzi - I think the question I would ask is whether there are going to be other items we need to store (e.g., uploads). If so, are we then creating multiple directories?

IMO, I think Laravel gets this fairly spot on in their app structure.

[innocenzi]

I'm not sure I understand what you're asking. Local storage would be in .tempest/storage by default, in tests it would be .tempest/tests/storage/{tag}. Users may create additional storages wherever they want, if they chose to use internal_storage_path('/some/path') that would be relative to .tempest.

[aidan-casey]

I'm of the mind storage is more clear to user since it will include uploads, etc.

While I can appreciate the concept of a hidden directory, I can just imagine the number of people trying to figure out where the files are because they didn't list hidden directories, etc.

[innocenzi]

As far as I know, PhpStorm, WebStorm and VSC all show dot files and directories. A storage directory wouldn't feel like an "internal storage" though, and we'd have to move stuff like current_discovery_strategy somewhere else, right?

[brendt]

Yeah I think .tempest is the most obvious name, actually.