-
-
Notifications
You must be signed in to change notification settings - Fork 142
feat(console): accept BackedEnum as command arguments
#722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
innocenzi
merged 4 commits into
tempestphp:main
from
aazsamir:feat/console_enum_arguments
Nov 13, 2024
Merged
feat(console): accept BackedEnum as command arguments
#722
innocenzi
merged 4 commits into
tempestphp:main
from
aazsamir:feat/console_enum_arguments
Nov 13, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BackedEnum as command arguments
innocenzi
reviewed
Nov 13, 2024
Member
innocenzi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome PR, I only have a few optional style nitpicks 👍
Pull Request Test Coverage Report for Build 11824085076Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
innocenzi
approved these changes
Nov 13, 2024
Member
|
Thanks! |
brendt
pushed a commit
that referenced
this pull request
Nov 14, 2024
Blurazzle
pushed a commit
to Blurazzle/tempest-framework
that referenced
this pull request
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request brings possibility of using enums as command arguments.
So this will be possible
Call
in case of wrong value:
And definition will be displayed as