Skip to content

Conversation

@brendt
Copy link
Member

@brendt brendt commented Nov 16, 2024

Closes #697

@innocenzi innocenzi changed the title refactor(core): pathhelper refactor to immutable class refactor(core): convert PathHelper to immutable class Nov 16, 2024
@innocenzi innocenzi changed the title refactor(core): convert PathHelper to immutable class refactor(supprot): convert PathHelper to immutable class Nov 16, 2024
@innocenzi innocenzi changed the title refactor(supprot): convert PathHelper to immutable class refactor(support): convert PathHelper to immutable class Nov 16, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11890648572

Details

  • 97 of 122 (79.51%) changed or added relevant lines in 19 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 81.944%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Tempest/Console/src/Initializers/LogOutputBufferInitializer.php 0 1 0.0%
src/Tempest/View/src/Renderers/TempestViewCompiler.php 0 1 0.0%
src/Tempest/Console/src/ConsoleApplication.php 0 2 0.0%
src/Tempest/Core/src/Kernel/LoadDiscoveryLocations.php 10 12 83.33%
src/Tempest/Http/src/HttpApplication.php 0 2 0.0%
src/Tempest/Support/src/NamespaceHelper.php 39 44 88.64%
src/Tempest/Support/src/PathHelper.php 21 33 63.64%
Totals Coverage Status
Change from base Build 11883856089: -0.1%
Covered Lines: 7847
Relevant Lines: 9576

💛 - Coveralls

@brendt brendt marked this pull request as ready for review November 18, 2024 10:51
@brendt
Copy link
Member Author

brendt commented Nov 18, 2024

Tests are failing because of component-dependencies

@brendt brendt merged commit 0dacd10 into main Nov 18, 2024
39 of 56 checks passed
@brendt brendt deleted the path-refactor branch November 18, 2024 11:49
Blurazzle pushed a commit to Blurazzle/tempest-framework that referenced this pull request Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor PathHelper with immutable chainable methods instead of static methods

3 participants