Skip to content

fix: Quote s3 path to handle special characters #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mgxd merged 2 commits into from
Aug 20, 2025
Merged

fix: Quote s3 path to handle special characters #147

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8efe107
fix: Quote s3 path to handle special characters
effigies Aug 20, 2025
e9510f3
Update templateflow/api.py
mgxd Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion templateflow/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,11 +309,12 @@ def _datalad_get(filepath):

def _s3_get(filepath):
from sys import stderr
from urllib.request import quote

import requests
from tqdm import tqdm

path = filepath.relative_to(TF_LAYOUT.root).as_posix()
path = quote(filepath.relative_to(TF_LAYOUT.root).as_posix())
url = f'{TF_S3_ROOT}/{path}'

print(f'Downloading {url}', file=stderr)
Expand Down
Loading