Skip to content

Re-enable test visiting payloads in error details #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yuandrew merged 3 commits into from
Apr 24, 2025
Merged

Re-enable test visiting payloads in error details #219

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3e4fc98
Enable section of test that is now supported
yuandrew Apr 23, 2025
5019332
Forgot a change
yuandrew Apr 23, 2025
aae2fdc
Merge branch 'master' into 1864-followup
yuandrew Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions proxy/interceptor_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,9 +498,7 @@ func TestClientInterceptorGrpcFailures(t *testing.T) {
// We expect that even though an error is returned, the Payload visitor visited the payload
// included in the GRPC error details
require.Error(err)
// TODO: https://github.com/temporalio/sdk-go/issues/1864
// This check should be switched to True once the issue above is closed
require.False(proto.Equal(inputs.Payloads[0], inboundPayload))
require.True(proto.Equal(inputs.Payloads[0], inboundPayload))
stat, ok := status.FromError(err)
require.True(ok)
for _, detail := range stat.Details() {
Expand All @@ -509,13 +507,12 @@ func TestClientInterceptorGrpcFailures(t *testing.T) {
multiOpFailure := &errordetails.MultiOperationExecutionFailure{}
err = detailAny.UnmarshalTo(multiOpFailure)
require.NoError(err)
payload := &common.Payload{}
err = multiOpFailure.Statuses[0].Details[0].UnmarshalTo(payload)
payloads := &common.Payloads{}
err = multiOpFailure.Statuses[0].Details[0].UnmarshalTo(payloads)
require.NoError(err)

newPayload := &common.Payload{Data: []byte("new-val")}
// This check should be switched to True once the issue above is closed
require.False(proto.Equal(newPayload, multiOpFailure.Statuses[0].Details[0]))
require.True(proto.Equal(payloads.Payloads[0], newPayload))
}

_, err = client.QueryWorkflow(context.Background(), &workflowservice.QueryWorkflowRequest{})
Expand Down Expand Up @@ -618,7 +615,7 @@ func (t *testGRPCServer) PollActivityTaskQueue(
func (t *testGRPCServer) ExecuteMultiOperation(
ctx context.Context,
req *workflowservice.ExecuteMultiOperationRequest) (*workflowservice.ExecuteMultiOperationResponse, error) {
anyDetail, err := anypb.New(inputPayload())
anyDetail, err := anypb.New(inputPayloads())
if err != nil {
return nil, err
}
Expand Down