Skip to content

Add NamespaceUnavailableFailure #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bergundy merged 2 commits into from
Nov 19, 2024
Merged

Add NamespaceUnavailableFailure #481

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2bdc410
Add NamespaceUnavailableFailure
bergundy Nov 19, 2024
add5b67
Update temporal/api/errordetails/v1/message.proto
bergundy Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion temporal/api/errordetails/v1/message.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,13 @@ message NamespaceNotActiveFailure {
string active_cluster = 3;
}

// NamespaceUnavailableFailure is returned by the service when a request addresses a namespace that is unavailable. For
Copy link
Member

@yiminc yiminc Nov 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worth call out that this is transient error that should be retried.

Copy link
Member Author

@bergundy bergundy Nov 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's already captured by the fact that it's an unavailable error but I'll clarify.

// example, when a namespace is in the process of failing over between clusters.
// This is a transient error that should be automatically retried by clients.
message NamespaceUnavailableFailure {
string namespace = 1;
}

message NamespaceInvalidStateFailure {
string namespace = 1;
// Current state of the requested namespace.
Expand Down Expand Up @@ -130,4 +137,4 @@ message MultiOperationExecutionFailure {
string message = 2;
repeated google.protobuf.Any details = 3;
}
}
}
Loading