Deprecate WorkerVersionStamp and replace it with Deployment #484
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -351,6 +351,7 @@ message RespondWorkflowTaskCompletedRequest { | |
| // Version info of the worker who processed this task. This message's `build_id` field should | ||
| // always be set by SDKs. Workers opting into versioning will also set the `use_versioning` | ||
| // field to true. See message docstrings for more. | ||
| // Deprecated. Use `deployment` and `versioning_behavior` instead. | ||
| temporal.api.common.v1.WorkerVersionStamp worker_version_stamp = 10; | ||
|
Comment on lines
+354
to
355
Member
There was a problem hiding this comment. I'm guessing we don't do this consistently everywhere, but, I think deprecation warnings really should go first at the top of the comment. Also we probably want to use the official (I'd say let's apply this everywhere we're deprecating things for this)
Contributor
Author
There was a problem hiding this comment. Good to know. I'll add the official deprecation tag in my next PR. |
||
| // Default versioning behavior that is set at worker server level. | ||
| // Protocol messages piggybacking on a WFT as a transport | ||
|
|
@@ -362,9 +363,12 @@ message RespondWorkflowTaskCompletedRequest { | |
| temporal.api.common.v1.MeteringMetadata metering_metadata = 13; | ||
| reserved 14; | ||
| reserved "capabilities"; | ||
|
Comment on lines
-365
to
-367
Contributor
Author
There was a problem hiding this comment. @antlai-temporal looking at the comment for versioning_behavior, I realized the stamp is not serving us well is v3 and is basically a twisted way of representing |
||
| // Deployment info of the worker that completed this task. Must be present if user has set | ||
| // `WorkerDeploymentOptions` regardless of versioning being enabled or not. | ||
| temporal.api.deployment.v1.Deployment deployment = 15; | ||
| // Versioning behavior of this workflow execution as set on the worker that completed this task. | ||
| // UNSPECIFIED means versioning is not enabled in the worker. | ||
| temporal.api.enums.v1.VersioningBehavior versioning_behavior = 16; | ||
| } | ||
|
|
||
| message RespondWorkflowTaskCompletedResponse { | ||
|
|
@@ -397,7 +401,11 @@ message RespondWorkflowTaskFailedRequest { | |
| // Version info of the worker who processed this task. This message's `build_id` field should | ||
| // always be set by SDKs. Workers opting into versioning will also set the `use_versioning` | ||
| // field to true. See message docstrings for more. | ||
| // Deprecated. Use `deployment` instead. | ||
| temporal.api.common.v1.WorkerVersionStamp worker_version = 8; | ||
| // Deployment info of the worker that completed this task. Must be present if user has set | ||
| // `WorkerDeploymentOptions` regardless of versioning being enabled or not. | ||
| temporal.api.deployment.v1.Deployment deployment = 9; | ||
| } | ||
|
|
||
| message RespondWorkflowTaskFailedResponse { | ||
|
|
@@ -510,7 +518,11 @@ message RespondActivityTaskCompletedRequest { | |
| // Version info of the worker who processed this task. This message's `build_id` field should | ||
| // always be set by SDKs. Workers opting into versioning will also set the `use_versioning` | ||
| // field to true. See message docstrings for more. | ||
| // Deprecated. Use `deployment` instead. | ||
| temporal.api.common.v1.WorkerVersionStamp worker_version = 5; | ||
| // Deployment info of the worker that completed this task. Must be present if user has set | ||
| // `WorkerDeploymentOptions` regardless of versioning being enabled or not. | ||
| temporal.api.deployment.v1.Deployment deployment = 6; | ||
| } | ||
|
|
||
| message RespondActivityTaskCompletedResponse { | ||
|
|
@@ -547,7 +559,11 @@ message RespondActivityTaskFailedRequest { | |
| // Version info of the worker who processed this task. This message's `build_id` field should | ||
| // always be set by SDKs. Workers opting into versioning will also set the `use_versioning` | ||
| // field to true. See message docstrings for more. | ||
| // Deprecated. Use `deployment` instead. | ||
| temporal.api.common.v1.WorkerVersionStamp worker_version = 6; | ||
| // Deployment info of the worker that completed this task. Must be present if user has set | ||
| // `WorkerDeploymentOptions` regardless of versioning being enabled or not. | ||
| temporal.api.deployment.v1.Deployment deployment = 7; | ||
| } | ||
|
|
||
| message RespondActivityTaskFailedResponse { | ||
|
|
@@ -590,7 +606,11 @@ message RespondActivityTaskCanceledRequest { | |
| // Version info of the worker who processed this task. This message's `build_id` field should | ||
| // always be set by SDKs. Workers opting into versioning will also set the `use_versioning` | ||
| // field to true. See message docstrings for more. | ||
| // Deprecated. Use `deployment` instead. | ||
| temporal.api.common.v1.WorkerVersionStamp worker_version = 5; | ||
| // Deployment info of the worker that completed this task. Must be present if user has set | ||
| // `WorkerDeploymentOptions` regardless of versioning being enabled or not. | ||
| temporal.api.deployment.v1.Deployment deployment = 6; | ||
| } | ||
|
|
||
| message RespondActivityTaskCanceledResponse { | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait why is this both newly added and already deprecated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because we first added it. then I removed it in #483, then I realized it will break recent SDK changes that @antlai-temporal made in versioning-3 branch, then I added back in this PR as deprecated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if we don't need it and it is just in my branch we could just delete it...