Skip to content
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions .github/workflows/push-to-buf.yml
Copy link
Member

@cretz cretz Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we test this before merging? I would like to confirm protos under google/ aren't published. You can request internally for the secret to be set (it should be set GH org wide, not just in this repo IMO). You may need to temporarily enable this to push on PR to test.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good point.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM

Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
name: Push to Buf Registry

on:
push:
tags:
- '**'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want this for every tag? Should it be only v** tags?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated ✅

branches:
- master
Comment on lines 3 to 8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pardon my lack of buf knowledge, can I get some clarity on how versioning is handled? This isn't doing anything to buf when we make a new tag in this repository, should it?

Copy link
Contributor Author

@nikki-dag nikki-dag Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a new tags trigger and successfully tagged my personal buf registry:

image

This way other repositories can depend on a specific release:
https://buf.build/docs/bsr/module/dependency-management/

code: https://github.com/nikki-dag/api
repo: https://buf.build/nikki/api
actions run: https://github.com/nikki-dag/api/actions/runs/12662329218/job/35287043167

permissions:
contents: read
jobs:
publish:
runs-on: ubuntu-latest
steps:
- name: Checkout repo
uses: actions/checkout@v4
- uses: bufbuild/buf-action@v1
with:
version: 1.49.0
token: ${{ secrets.BUF_TOKEN }}
1 change: 1 addition & 0 deletions buf.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
version: v1
name: buf.build/temporalio/api
deps:
- buf.build/grpc-ecosystem/grpc-gateway
- buf.build/googleapis/googleapis
Expand Down
Loading