Add completion callbacks to SignalWithStart request #529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergundy
reviewed
Jan 24, 2025
Member
bergundy
left a comment
bergundy
left a comment
There was a problem hiding this comment.
We don't need this for Nexus FTR, SignalWithStartOperation is about sending the signal and immediately completing, we don't want to tie the operation completion to the workflow completion.
cretz
reviewed
Jan 24, 2025
| temporal.api.workflow.v1.VersioningOverride versioning_override = 25; | ||
| // Callbacks to be called by the server when this workflow reaches a terminal state. | ||
| // If the workflow continues-as-new, these callbacks will be carried over to the new execution. | ||
| // Callbacks will not be deduplicated if the workflow is already started with callbacks. |
Member
There was a problem hiding this comment.
What happens to this list when a workflow already exists? Is it discarded like it is for other start calls that don't start a workflow? Can we accept OnConflictOptions from #510 to be clear what side effecting action is taken on already-existing workflows?
Contributor
Author
|
Decided this is not required for Nexus, so no need to add it right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READ BEFORE MERGING: All PRs require approval by both Server AND SDK teams before merging! This is why the number of required approvals is "2" and not "1"--two reviewers from the same team is NOT sufficient. If your PR is not approved by someone in BOTH teams, it may be summarily reverted.
What changed?
Adding a new field for completion callbacks to
SignalWithStartWorkflowExecutionRequestWhy?
So that Nexus operations which use SignalWithStart can be informed of the workflow's completion.
Breaking changes
Server PR