Add blob and memo limits to NamespaceInfo #670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
approved these changes
Nov 24, 2025
simvlad
force-pushed
the
simvlad/send-blob-size-err-limit
branch
2 times, most recently
from
9396af6 to
10a8221
Compare
yycptt
approved these changes
Nov 25, 2025
simvlad
changed the title
yycptt
approved these changes
Nov 25, 2025
Quinn-With-Two-Ns
approved these changes
Nov 26, 2025
simvlad
force-pushed
the
simvlad/send-blob-size-err-limit
branch
from
d6761e9 to
c49f9b0
Compare
3 tasks
simvlad
added a commit
to temporalio/temporal
that referenced
this pull request
Dec 12, 2025
## What changed? Populates BlobSizeLimitError and MemoSizeLimitError in the response for DescribeNamespace ## Why? Currently the BlobSizeLimitError and MemoSizeLimitError are terminating the workflow with the check performed on the server. In order, for SDK to enforce and fail workflow task, we need to pass those to the SDK. temporalio/api#670 is the change that added those limits to the NamespaceInfo structure. ## How did you test it? - [X] built - [X] run locally and tested manually - [X] added new unit test(s) ## Potential risks No risks, as those are not used yet.
chaptersix
pushed a commit
to chaptersix/temporal
that referenced
this pull request
Dec 15, 2025
…8734) ## What changed? Populates BlobSizeLimitError and MemoSizeLimitError in the response for DescribeNamespace ## Why? Currently the BlobSizeLimitError and MemoSizeLimitError are terminating the workflow with the check performed on the server. In order, for SDK to enforce and fail workflow task, we need to pass those to the SDK. temporalio/api#670 is the change that added those limits to the NamespaceInfo structure. ## How did you test it? - [X] built - [X] run locally and tested manually - [X] added new unit test(s) ## Potential risks No risks, as those are not used yet.
awln-temporal
pushed a commit
to temporalio/temporal
that referenced
this pull request
Dec 18, 2025
## What changed? Populates BlobSizeLimitError and MemoSizeLimitError in the response for DescribeNamespace ## Why? Currently the BlobSizeLimitError and MemoSizeLimitError are terminating the workflow with the check performed on the server. In order, for SDK to enforce and fail workflow task, we need to pass those to the SDK. temporalio/api#670 is the change that added those limits to the NamespaceInfo structure. ## How did you test it? - [X] built - [X] run locally and tested manually - [X] added new unit test(s) ## Potential risks No risks, as those are not used yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what has changed in this PR
Add
blob_size_limit_errorandmemo_size_limit_errorto NamespaceInfoTell your future self why have you made these changes
blob_size_limit_erroris the maximum size in bytes for payload fields in workflow history events (e.g., workflow/activity inputs and results, failure details, signal payloads). When exceeded, the server will reject the operation with an error.memo_size_limit_erroris the maximum total memo size in bytes per workflow execution.Today, the size limit for input payloads is enforced on the server. SDK doesn't have a reliable way to know whether the request will be rejected on the server, because the size of the fields in the request exceeds namespace-level configured
blob_size_limit_errorandmemo_size_limit_error. The motivation here, is for SDK to be able to do the check, failing the workflow task, allowing the user to fix the failure, rather than terminating the workflow on the server.Are there any breaking changes on binary or code level?
No
If this breaks the Server, please provide the Server PR to merge right after this PR was merged.
N/A