Skip to content

Proposes visibility field for namespace #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mastermanu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Proposes visibility field for namespace #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions temporal/api/cloud/cloudservice/v1/request_response.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,8 @@ message GetNamespacesRequest {
// Filter namespaces by their name.
// Optional, defaults to empty.
string name = 3;
// Optional, defaults to showing only namespaces the calling principal has permissions for
temporal.api.cloud.namespace.v1.NamespaceVisibility visibility = 4;
}

message GetNamespacesResponse {
Expand Down
1 change: 1 addition & 0 deletions temporal/api/cloud/identity/v1/message.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,3 +69,4 @@ message User {
// Will not be set if the user has never been modified.
google.protobuf.Timestamp last_modified_time = 8;
}

15 changes: 15 additions & 0 deletions temporal/api/cloud/namespace/v1/message.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,4 +130,19 @@ message Namespace {
// The date and time when the namespace was last modified.
// Will not be set if the namespace has never been modified.
google.protobuf.Timestamp last_modified_time = 11;
// Indicates which principals in the account can see that the namespace exists and view its configuration
NamespaceVisibility visibility = 12;
}

// Indicates which principals in an account are able to see that the namespace exists and view its configuration.
enum NamespaceVisibility {
// Unspecified defaults to NAMESPACE_VISIBILITY_PERMISSIONS_REQUIRED
NAMESPACE_VISIBILITY_LEVEL_UNSPECIFIED = 0;

// A principal must have some form of permissions to the namespace in order to be able to see that it exists and view its configuration
NAMESPACE_VISIBILITY_LEVEL_PERMISSIONS_REQUIRED = 1;

// Any principal can see the namespace exists and view its configuration. Note that the actual namespace data (e.g. Workflows)
// still cannot be accessed by a principal without the appropriate namespace permissions attached to it.
NAMESPACE_VISIBILITY_LEVEL_ALL_DEVELOPERS = 2;
}