Add Publish to Buf Github Action #56
Conversation
.github/workflows/push-to-buf.yml
Outdated
| branches: | ||
| - master |
There was a problem hiding this comment.
Even though this has no tags yet, we should consider still triggering on them for the one day it actually might
There was a problem hiding this comment.
Updated ✅ (Assuming our version tags will also start with v)
There was a problem hiding this comment.
Yes we have started cutting release tags now, lets make sure we push them to buf too.
buf.yaml
Outdated
| @@ -1,4 +1,5 @@ | |||
| version: v1 | |||
| name: buf.build/temporalio/api-cloud | |||
There was a problem hiding this comment.
As part of internal discussions concerning the future of cloud repos, I have proposed that if/when we get to multiple cloud-specific developer experience repos, they would all be prefixed with cloud- which includes renaming this repository to cloud-api instead of api-cloud. I wonder if we should think about making the buf repo as cloud-api now or at least confirm that we don't think it'll be too harmful to users if/when we do it later (but before cloud API is considered stable).
There was a problem hiding this comment.
If we eventually rename this repo to cloud-api, it makes sense to me to name the buf registry cloud-api now. What do you think, @anekkanti?
There was a problem hiding this comment.
To clarify, this decision has not been made, it is part of a proposal under discussion internally along with other things. It's possible it never gets renamed.
There was a problem hiding this comment.
The repo has been changed to cloud-api. @nikki-dag please go ahead and change the buf registry to cloud-api as well.
nikki-dag
force-pushed
the
nikki/publish-to-buf
branch
from
e806ca7 to
0e533bb
Compare
temporalio/api#508 (comment)
Tested with my PR branch:
