-
Notifications
You must be signed in to change notification settings - Fork 283
EDU-3544: [PHP] Update Message passing page #3207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
brianmacdonald-temporal
merged 14 commits into
temporalio:main
from
roxblnfk:php-message-handler-pattern
Dec 5, 2024
Merged
EDU-3544: [PHP] Update Message passing page #3207
brianmacdonald-temporal
merged 14 commits into
temporalio:main
from
roxblnfk:php-message-handler-pattern
Dec 5, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianmacdonald-temporal
approved these changes
Dec 5, 2024
Contributor
brianmacdonald-temporal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These additions look good to me. They're tightly modeled on the /python/message-passing page, which also seems to be in good shape.
stephanos
pushed a commit
to stephanos/documentation
that referenced
this pull request
Dec 9, 2024
* Add `Message handler patterns` headers from python docs * Describe Workflow::allHandlersFinished * Describe "Add wait conditions to block" * Describe mutex usage in concurrent handler execution * Describe "Use wait conditions in handlers" * Describe a part of message handler troubleshooting * Describe a part of problems when sending a Query * Describe a part of problems when sending an Update * Add a part of problems when sending an Update * Add a part of problems when sending an Update * Cleanup; update index * Remove mention of `WorkflowUpdateResultException` * Update docs/develop/php/message-passing.mdx --------- Co-authored-by: Brian MacDonald <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds information to the "Message Passing" page, similar to the Python documentation.
Notes to reviewers
Waiting for: