feat: visual comparison CI workflow #3884
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![semgrep-managed-scans[bot]](https://avatars.githubusercontent.com/u/56493103?s=60&v=4){kind=small}
| - run: | | ||
| echo "Visual comparison enabled for this run" | ||
| echo "base ref: ${{ github.base_ref }}" | ||
| echo "head ref: ${{ github.head_ref }}" | ||
| echo "report path: ${{ env.HTML_REPORT_URL_PATH }}" | ||
|
|
There was a problem hiding this comment.
Using variable interpolation ${{...}} with github context data in a run: step could allow an attacker to inject their own code into the runner. This would allow them to steal secrets and code. github context data can have arbitrary user input and should be treated as untrusted. Instead, use an intermediate environment variable with env: to store the data and use the environment variable in the run: script. Be sure to use double-quotes the environment variable, like this: "$ENVVAR".
🚀 Fixed in commit 5fb6ce4 🚀
lennessyy
changed the title
| run: | | ||
| echo "GITHUB_BASE_REF: ${{ github.base_ref }}" | ||
| echo "GITHUB_HEAD_REF: ${{ github.head_ref }}" | ||
| echo "GITHUB_REF_NAME: ${{ github.ref_name }}" | ||
| echo "HTML_REPORT_URL_PATH ${{ env.HTML_REPORT_URL_PATH }}" | ||
|
|
There was a problem hiding this comment.
Semgrep identified a blocking 🔴 issue in your code:
Using variable interpolation ${{...}} with github context data in a run: step could allow an attacker to inject their own code into the runner. This would allow them to steal secrets and code. github context data can have arbitrary user input and should be treated as untrusted. Instead, use an intermediate environment variable with env: to store the data and use the environment variable in the run: script. Be sure to use double-quotes the environment variable, like this: "$ENVVAR".
To resolve this comment:
🔧 No guidance has been designated for this issue. Fix according to your organization's approved methods.
💬 Ignore this finding
Reply with Semgrep commands to ignore this finding.
/fp <comment>for false positive/ar <comment>for acceptable risk/other <comment>for all other reasons
Alternatively, triage in Semgrep AppSec Platform to ignore the finding created by run-shell-injection.
You can view more details about this finding in the Semgrep AppSec Platform.
What does this PR do?
Notes to reviewers