Add clusterMetadata to clusterName to easily rename a cluster #843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Add
server.config.clusterMetadata.clusterNamewhere if it's the only field in clusterMetadata, it's used with the default clusterMetadata with just the name change. It's fully compatible with the existing values (unless someone had specifiedclusterMetadata.clusterNamewhich is unlikely, since that's a unused field in config)Remove
rpcNamein clusterMetadata. It was removed from temporal config in 2021.Why?
To make it easier to customize just the clusterName.
If anything else needs to be customized, whole clusterMetadata has to be provided.
Checklist
Closes
How was this tested:
Ran
helm template .between main and this branch, and verified that only diff is removal ofrpcNameand config checksum.