Skip to content

Conversation

@rustatian
Copy link
Collaborator

@rustatian rustatian commented Sep 10, 2025

Reason for This PR

closes: roadrunner-server/roadrunner#2233

Description of Changes

  • Handle NO_PROXY env.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

@rustatian rustatian self-assigned this Sep 10, 2025
@rustatian rustatian added the C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc.. label Sep 10, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for the NO_PROXY environment variable in the Temporal client configuration and updates various dependencies to newer versions.

  • Adds handling for the NO_PROXY environment variable to conditionally disable proxy usage in gRPC connections
  • Updates Go module dependencies including Temporal API, various Google and gRPC packages
  • Refactors dial options construction to support conditional proxy configuration

Reviewed Changes

Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.

File Description
internal.go Adds NO_PROXY environment variable support and refactors gRPC dial options construction
tests/go.mod Updates test dependencies to newer versions
go.mod Updates main module dependencies
go.work.sum Updates workspace dependency checksums
Comments suppressed due to low confidence (2)

tests/go.mod:1

  • Go version 1.25 does not exist. The latest stable version as of my knowledge cutoff is Go 1.23. Please use a valid Go version.
module tests

go.mod:1

  • Go version 1.25 does not exist. The latest stable version as of my knowledge cutoff is Go 1.23. Please use a valid Go version.
module github.com/temporalio/roadrunner-temporal/v5

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@rustatian rustatian changed the title feature: handle NO_PROXY environment varialbe feature: handle NO_PROXY environment variable Sep 10, 2025
Signed-off-by: Valery Piashchynski <[email protected]>
@rustatian rustatian merged commit 4628cf5 into master Sep 10, 2025
9 of 10 checks passed
@rustatian rustatian deleted the feature/2233-support-no-proxy branch September 10, 2025 15:07
@jur3
Copy link

jur3 commented Sep 11, 2025

I think this is not a correct implementation of the NO_PROXY environment variable. The implementation disables the proxy for all domains, not just for the domains listed in NO_PROXY.

The NO_PROXY environment variable usually contains a comma-separated list of domains for which the proxy should not be used.

@rustatian
Copy link
Collaborator Author

Comma-separated env is used if you need to control many resources. Here we have only 1 resource - gRPC connection, thus it can be only True/False.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc..

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[💡 FEATURE REQUEST]: Temporal: support NO_PROXY env variable

4 participants