Skip to content

Conversation

@rustatian
Copy link
Collaborator

Reason for This PR

closes: roadrunner-server/roadrunner#2239

Description of Changes

  • Support Summary for the via the LA options.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

@rustatian rustatian requested a review from Copilot October 2, 2025 17:36
@rustatian rustatian self-assigned this Oct 2, 2025
@rustatian rustatian added the C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc.. label Oct 2, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for the Summary field in Local Activity (LA) options for the Temporal plugin. The main purpose is to allow developers to specify a summary when executing local activities.

  • Added Summary field to ExecuteLocalActivityOptions struct
  • Updated JSON tags to remove omitempty for better serialization consistency
  • Refactored for loops to use range-only syntax for improved readability

Reviewed Changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
internal/protocol.go Added Summary field to ExecuteLocalActivityOptions and updated JSON serialization
status.go Refactored for loops to use range syntax
plugin.go Refactored for loops to use range syntax
metrics.go Refactored for loops to use range syntax
internal/worker_info.go Removed omitempty from Options JSON tag
internal/codec/proto/proto.go Refactored for loops to use range syntax
internal.go Refactored for loops and updated function signature to use any instead of interface{}
info.go Refactored for loops to use range syntax
go.mod Updated dependency versions
go.work.sum Updated dependency checksums

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@rustatian rustatian requested a review from wolfy-j October 2, 2025 17:36
rustatian and others added 2 commits October 2, 2025 19:45
Signed-off-by: Valery Piashchynski <[email protected]>
@rustatian rustatian merged commit 659564c into master Oct 2, 2025
11 checks passed
@rustatian rustatian deleted the feature/support-la-summary branch October 2, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc..

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[💡 FEATURE REQUEST]: Summary for local activity

3 participants