Skip to content

Conversation

@roxblnfk
Copy link
Contributor

@roxblnfk roxblnfk commented Oct 8, 2025

Reason for This PR

React Promise v3 (cross dependency) has changed signature of the PromiseInterface::resolve() that requires a values as the first argument now.

Description of Changes

Fixed CancelSignaledChildWorkflow test.
Increased min PHP SDK version to 2.16.0 in composer.json

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

@roxblnfk roxblnfk requested a review from rustatian as a code owner October 8, 2025 10:33
@rustatian rustatian added the A-CI Area: CI CD label Oct 8, 2025
@rustatian rustatian changed the title Fix CancelSignaledChildWorkflow test fix: CancelSignaledChildWorkflow test Oct 8, 2025
@rustatian rustatian merged commit 46e71b6 into temporalio:master Oct 8, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CI Area: CI CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants