Skip to content

Waiting activity completion after ExecuteActivityCall #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cretz merged 2 commits into from
Jan 23, 2025
Merged

Waiting activity completion after ExecuteActivityCall #382

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c95770
Waiting activity completion after ExecuteActivityCall
edmondop Jan 23, 2025
62d7468
Adding correct error handling and unit test cases
edmondop Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions choice-exclusive/workflow.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,14 @@ func ExclusiveChoiceWorkflow(ctx workflow.Context) error {
// choose next activity based on order result
switch orderChoice {
case OrderChoiceApple:
workflow.ExecuteActivity(ctx, orderActivities.OrderApple, orderChoice)
workflow.ExecuteActivity(ctx, orderActivities.OrderApple, orderChoice).Get(ctx, nil)
Copy link
Member

@cretz cretz Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good change, but we need to handle the errors coming back from these

case OrderChoiceBanana:
workflow.ExecuteActivity(ctx, orderActivities.OrderBanana, orderChoice)
workflow.ExecuteActivity(ctx, orderActivities.OrderBanana, orderChoice).Get(ctx, nil)
case OrderChoiceCherry:
workflow.ExecuteActivity(ctx, orderActivities.OrderCherry, orderChoice)
workflow.ExecuteActivity(ctx, orderActivities.OrderCherry, orderChoice).Get(ctx, nil)
case OrderChoiceOrange:
// Activity can be also called by its name
workflow.ExecuteActivity(ctx, "OrderOrange", orderChoice)
workflow.ExecuteActivity(ctx, "OrderOrange", orderChoice).Get(ctx, nil)
default:
logger.Error("Unexpected order", "Choice", orderChoice)
}
Expand Down