[DRAFT] Fix LA completion order on replay #1035
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
When multiple LAs run concurrently (i.e. started from the same Workflow Activation), Core records LA markers in the order that the activities completed, and queue up lang jobs in that same order, which is the expected behavior.
However, on replay, Core would previously queue LA completion jobs in the order that the LAs are started by the workflow, which could have resulted in NDEs on replay in the rare case where other commands are scheduled by the workflow on completion of each LA independently (i.e. rather than on completion of all the LAs). See this issue for example.
This incorrect behavior is that we'd previously look ahead for an LA completion on creation, immediately switching to the
ReplayingPreResolvedstate in such case, which would record the LA completion job.This PR fixes this behavior by:
WaitingResolveFromMarkerLookAheadstate (i.e. they can't be "preresolved");Map<seq_number, result>;