Bon conversion #1074
Open
Bon conversion #1074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sushisource
commented
Dec 5, 2025
| #[derive(Clone, bon::Builder)] | ||
| #[builder(on(String, into), state_mod(vis = "pub"), finish_fn(vis = "", name = build_internal))] | ||
| #[non_exhaustive] | ||
| pub struct WorkerConfig { |
Member
Author
There was a problem hiding this comment.
My biggest annoyance with this PR is that bon makes building partially-fulfilled builders somewhat difficult. It's better in every other respect than derive_builder, but this limitation makes the test code slightly worse.
You will note there are many places now where, previously, we updated the builder inside a CoreWfStarter for example, but now we have to directly mutate fields on the built WorkerConfig. This is not ideal because it bypasses validation.
However, I'm not hugely concerned about that since, ultimately, this struct probably doesn't need to become public and the Rust SDK can export its own (nearly identical) version, where we will make the fields private and add getters.
Sushisource
force-pushed
the
bon-conversion
branch
from
f5eaf69 to
97db55e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Why?
Checklist
Closes
How was this tested: