Add dependency injection support for Nexus services #561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Add [dependency injection[(https://learn.microsoft.com/en-us/dotnet/core/extensions/dependency-injection) support for Nexus services, similar to that of activities. Public methods were named similar to the Activity-based counter parts.
Why?
Enable registration of Nexus services via dependency injection in .NET host applications.
Checklist
Closes [Feature Request] Support Nexus in
Temporalio.Extensions.Hosting#536How was this tested:
[ ] Tests are not implemented yet
Any docs updates needed?
[ ] Will check with team where appropriate documentation should be done in repo.
[ ] Will check with team if docs.temporal.io needs to be updated.
[ ] Proposing to add new samples to https://github.com/temporalio/samples-dotnet