Skip to content

Enable TestNexusTracingInterceptor if workflow cache is enabled #1851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Enable TestNexusTracingInterceptor if workflow cache is enabled #1851

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a572033
Enable TestNexusTracingInterceptor if workflow cache is enabled
bergundy Feb 25, 2025
31b69da
Merge branch 'master' into tracing-interceptor-test-enable
bergundy Feb 26, 2025
ed2fea2
Merge branch 'master' into tracing-interceptor-test-enable
bergundy Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion test/nexus_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2404,7 +2404,9 @@ func (t *otelTracer) spanChildren(spans []sdktrace.ReadOnlySpan, parentID trace.
}

func TestNexusTracingInterceptor(t *testing.T) {
t.Skip("this test is flaky in CI and needs to be restructured")
if os.Getenv("WORKFLOW_CACHE_SIZE") == "0" {
t.Skip("TestNexusTracingInterceptor not supported with 0 workflow cache size")
}
cases := []struct {
name string
tracer func(t *testing.T) interceptortest.TestTracer
Expand Down
Loading