Fix caching in LazyUpdateHandleImpl (#2098)

Quinn-With-Two-Ns · web-flow · commit 42b98035049c · 2024-06-06T14:38:44.000-07:00
* Fix caching in LazyUpdateHandleImpl

* Fix dumb condition mistake
diff --git a/temporal-sdk/src/main/java/io/temporal/client/LazyUpdateHandleImpl.java b/temporal-sdk/src/main/java/io/temporal/client/LazyUpdateHandleImpl.java
@@ -75,7 +75,6 @@ public String getId() {
   public CompletableFuture<T> getResultAsync(long timeout, TimeUnit unit) {
 
     WorkflowClientCallsInterceptor.PollWorkflowUpdateOutput<T> pollCall = null;
-    boolean setFromWaitCompleted = false;
 
     // If waitCompleted was called, use the result from that call.
     synchronized (this) {
@@ -85,7 +84,7 @@ public CompletableFuture<T> getResultAsync(long timeout, TimeUnit unit) {
       }
     }
 
-    if (!setFromWaitCompleted) {
+    if (pollCall == null) {
       pollCall = pollUntilComplete(timeout, unit);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,6 @@ public String getId() {`
`75`	`75`	`public CompletableFuture<T> getResultAsync(long timeout, TimeUnit unit) {`
`76`	`76`
`77`	`77`	`WorkflowClientCallsInterceptor.PollWorkflowUpdateOutput<T> pollCall = null;`
`78`		`- boolean setFromWaitCompleted = false;`
`79`	`78`
`80`	`79`	`// If waitCompleted was called, use the result from that call.`
`81`	`80`	`synchronized (this) {`
`@@ -85,7 +84,7 @@ public CompletableFuture<T> getResultAsync(long timeout, TimeUnit unit) {`
`85`	`84`	`}`
`86`	`85`	`}`
`87`	`86`
`88`		`- if (!setFromWaitCompleted) {`
	`87`	`+ if (pollCall == null) {`
`89`	`88`	`pollCall = pollUntilComplete(timeout, unit);`
`90`	`89`	`}`
`91`	`90`