Upgrade otel & otel-shim to 1.50.0 #2532
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quinn-With-Two-Ns
force-pushed
the
fix-otel-version
branch
from
720c71f to
f207fc7
Compare
| @@ -1,7 +1,7 @@ | |||
| description = '''Spring Boot AutoConfigure for Temporal Java SDK''' | |||
|
|
|||
| ext { | |||
| otelVersion = '1.25.0' | |||
There was a problem hiding this comment.
I don't think we want to use 1.50.0 since it does't match our min. kotlin version and is the latest version of the dep., if you want to use this version then I would encourage you to manually override it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Upgrading
io.opentelemetry:opentelemetry-bomandi.o:opentelemetry-opentracing-shimto1.50.0.Why?
The opentracing version transitively referenced by
io.opentelemetryis0.26.0which is quite old and causing issues. Updating this aligns the version explicitly included bytemporal-opentracing.We could make an internal resolution rule for this, but it feels like the SDK should be using similar versions regardless of module being imported.
Checklist
./gradlew build check