Skip to content

Fix calling update method with unknown workflow type #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roxblnfk merged 1 commit into from
Jan 7, 2025
Merged

Fix calling update method with unknown workflow type #547

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion psalm-baseline.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,7 +428,6 @@
<code><![CDATA[$attr->getFailure()]]></code>
<code><![CDATA[$attr->getResult()]]></code>
<code><![CDATA[$input->workflowType]]></code>
<code><![CDATA[$input->workflowType]]></code>
<code><![CDATA[$result->getQueryResult()]]></code>
<code><![CDATA[$this->execution]]></code>
<code><![CDATA[$this->execution]]></code>
Expand Down
2 changes: 1 addition & 1 deletion src/Internal/Client/ResponseToResultMapper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public function __construct(
public function mapUpdateWorkflowResponse(
UpdateWorkflowExecutionResponse $result,
string $updateName,
string $workflowType,
?string $workflowType,
WorkflowExecution $workflowExecution,
): StartUpdateOutput {
$outcome = $result->getOutcome();
Expand Down
13 changes: 13 additions & 0 deletions tests/Acceptance/Extra/Update/UntypedStubTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,19 @@ public function fetchResultWithTimeout(
$this->assertSame(['key' => null], (array)$result, 'Workflow result contains resolved value');
}

#[Test]
public function useClientRunningWorkflowStub(
#[Stub('Extra_Update_UntypedStub')] WorkflowStubInterface $stub,
WorkflowClientInterface $client,
): void {
$untyped = $client->newUntypedRunningWorkflowStub(
$stub->getExecution()->getID(),
$stub->getExecution()->getRunID(),
);

$this->fetchResolvedResultAfterWorkflowCompleted($untyped);
}

#[Test]
public function handleUnknownUpdate(
#[Stub('Extra_Update_UntypedStub')] WorkflowStubInterface $stub,
Expand Down
Loading