Skip to content

Conversation

@roxblnfk
Copy link
Collaborator

@roxblnfk roxblnfk commented Jan 8, 2025

What was changed

  • ScheduleOptions->naemspace has null value by default instead of "default"
  • Deprecate namespace property and withNamespace() method in ScheduleOptions
  • Use namespace from the ClientOptions as a fallback value when a Schedule is created

Checklist

  1. Closes [Bug] Namespace from ClientOptions in ScheduleClient constructor not respected in createSchedule #548
  2. How was this tested: added unit tests

@vercel
Copy link

vercel bot commented Jan 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
php ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 8:35pm

@roxblnfk roxblnfk requested a review from wolfy-j January 8, 2025 20:33
@roxblnfk roxblnfk merged commit 34e49ca into master Jan 9, 2025
113 checks passed
@roxblnfk roxblnfk deleted the schedule-namespace branch January 9, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Namespace from ClientOptions in ScheduleClient constructor not respected in createSchedule

4 participants