Continuous polling in UpdateHandle::fetchResult() until deadline #591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
repeat the polling of update request until configured deadline
wolfy-j
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Replaced the approach in PR #526 by modifying
UpdateHandle::fetchResult()to repeatedly poll the Temporal service until either the configured deadline is reached or a response is received. This eliminates the need for a specialWorkflowUpdateResultExceptionwhen a Workflow Update Request is stuck in ADMITTED status.Why?
This implementation aligns with other Temporal SDKs by continuing to poll rather than throwing an exception when updates are stuck. This provides a more consistent behavior across Temporal implementations and better handles scenarios where workflows are delayed due to unavailable workers or failed workflow tasks.
Checklist