Skip to content

Fix php 8.4 deprecations in unit tests #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roxblnfk merged 1 commit into from
Dec 19, 2025
Merged

Fix php 8.4 deprecations in unit tests #672

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions tests/Unit/Declaration/Fixture/FixedReader.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

class FixedReader implements ReaderInterface
{
public function getClassMetadata(\ReflectionClass $class, string $name = null): iterable
public function getClassMetadata(\ReflectionClass $class, ?string $name = null): iterable
{
return [];
}
Expand All @@ -36,7 +36,7 @@ public function firstClassMetadata(\ReflectionClass $class, string $name): ?obje
return null;
}

public function getFunctionMetadata(\ReflectionFunctionAbstract $function, string $name = null): iterable
public function getFunctionMetadata(\ReflectionFunctionAbstract $function, ?string $name = null): iterable
{
return [];
}
Expand All @@ -50,7 +50,7 @@ public function firstFunctionMetadata(\ReflectionFunctionAbstract $function, str
return null;
}

public function getPropertyMetadata(\ReflectionProperty $property, string $name = null): iterable
public function getPropertyMetadata(\ReflectionProperty $property, ?string $name = null): iterable
{
return [];
}
Expand All @@ -60,7 +60,7 @@ public function firstPropertyMetadata(\ReflectionProperty $property, string $nam
return null;
}

public function getConstantMetadata(\ReflectionClassConstant $constant, string $name = null): iterable
public function getConstantMetadata(\ReflectionClassConstant $constant, ?string $name = null): iterable
{
return [];
}
Expand All @@ -70,7 +70,7 @@ public function firstConstantMetadata(\ReflectionClassConstant $constant, string
return null;
}

public function getParameterMetadata(\ReflectionParameter $parameter, string $name = null): iterable
public function getParameterMetadata(\ReflectionParameter $parameter, ?string $name = null): iterable
{
return [];
}
Expand Down
2 changes: 1 addition & 1 deletion tests/Unit/Worker/AutowiringTestCase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public static function reflectionDataProvider(): array
static::class . '->instanceMethod' => [new \ReflectionMethod($instance, 'instanceMethod')],

// Static Method
static::class . '::staticMethod' => [new \ReflectionMethod(static::class . '::staticMethod')],
static::class . '::staticMethod' => [new \ReflectionMethod(static::class, 'staticMethod')],

// Function
__NAMESPACE__ . '\\global_function' => [new \ReflectionFunction(__NAMESPACE__ . '\\global_function')],
Expand Down
Loading