Replayer plugin context #1016
Closed
Replayer plugin context #1016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
reviewed
Aug 4, 2025
|
|
||
| async def run_worker(self, worker: Worker) -> None: | ||
| @asynccontextmanager | ||
| async def run_worker(self) -> AsyncIterator[None]: |
Member
There was a problem hiding this comment.
People need to be able to access the worker and its options IMO. Running a replayer is not like running a worker and should not be combined with it IMO. What if it only makes sense for me to do something for activities or Nexus operations? If we want the default implementation of run_worker and run_replayer to delegate to another method called run_worker_or_replayer or something similarly named to represent the combination, we may be able to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Why?
Checklist
Closes
How was this tested: