Skip to content

Nexus: eliminate unused arguments #1022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dandavison merged 1 commit into from
Aug 8, 2025
Merged

Nexus: eliminate unused arguments #1022

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion temporalio/nexus/_decorators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ async def _start(
)

_start.__doc__ = start.__doc__
return WorkflowRunOperationHandler(_start, input_type, output_type)
return WorkflowRunOperationHandler(_start)

method_name = get_callable_name(start)
nexusrpc.set_operation_definition(
Expand Down
6 changes: 0 additions & 6 deletions temporalio/nexus/_operation_handlers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@
Any,
Awaitable,
Callable,
Optional,
Type,
)

from nexusrpc import (
Expand Down Expand Up @@ -50,8 +48,6 @@ def __init__(
[StartOperationContext, InputT],
Awaitable[WorkflowHandle[OutputT]],
],
input_type: Optional[Type[InputT]],
output_type: Optional[Type[OutputT]],
) -> None:
"""Initialize the workflow run operation handler."""
if not is_async_callable(start):
Expand All @@ -64,8 +60,6 @@ def __init__(
if start.__doc__:
if start_func := getattr(self.start, "__func__", None):
start_func.__doc__ = start.__doc__
self._input_type = input_type
self._output_type = output_type

async def start(
self, ctx: StartOperationContext, input: InputT
Expand Down