Skip to content

Add Summary to LocalActivityConfig and apis #1061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tconley1428 merged 15 commits into from
Sep 4, 2025
Merged

Add Summary to LocalActivityConfig and apis #1061

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
a943aa6
Adding summary to all local activity execution functions
tconley1428 Jul 30, 2025
2e75c6a
Add summary to LocalActivityConfig
tconley1428 Aug 27, 2025
ce5d3fe
Linting
tconley1428 Aug 28, 2025
2689132
Merge branch 'main' into local_activity_summary_updated
tconley1428 Aug 28, 2025
420f18f
Update Core
tconley1428 Aug 28, 2025
cf55cc0
Remove print
tconley1428 Sep 3, 2025
5e41582
Revert "Remove print"
tconley1428 Sep 3, 2025
05ab51e
Remove print
tconley1428 Sep 3, 2025
3664c6f
Merge remote-tracking branch 'origin/main' into local_activity_summar…
tconley1428 Sep 4, 2025
b3b8c46
Redo core update
tconley1428 Sep 4, 2025
8941946
Merge remote-tracking branch 'origin/main' into local_activity_summar…
tconley1428 Sep 4, 2025
d08faab
Update core
tconley1428 Sep 4, 2025
0fa6b41
Update protos
tconley1428 Sep 4, 2025
baea029
Format protos
tconley1428 Sep 4, 2025
869868f
Update cargo.lock
tconley1428 Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion temporalio/bridge/sdk-core
Open in desktop
Submodule sdk-core updated 18 files
+44 −48 ARCHITECTURE.md
+14 −0 arch_docs/diagrams/TimerMachine_Coverage.puml
+ − arch_docs/diagrams/initial_event_history.png
+0 −1 arch_docs/diagrams/workflow_internals.svg
+296 −0 arch_docs/sdks_intro.md
+3 −1 client/src/lib.rs
+124 −5 client/src/proxy.rs
+11 −0 core-c-bridge/include/temporal-sdk-core-c-bridge.h
+95 −7 core-c-bridge/src/worker.rs
+7 −1 core/src/protosext/mod.rs
+6 −4 core/src/worker/workflow/machines/local_activity_state_machine.rs
+1 −1 core/src/worker/workflow/machines/workflow_machines.rs
+10 −1 sdk/src/workflow_context/options.rs
+4 −0 test-utils/Cargo.toml
+135 −0 test-utils/src/http_proxy.rs
+2 −0 test-utils/src/lib.rs
+87 −9 tests/integ_tests/client_tests.rs
+52 −1 tests/integ_tests/workflow_tests/local_activities.rs
2 changes: 2 additions & 0 deletions temporalio/worker/_interceptor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,6 +352,8 @@ class StartLocalActivityInput:
local_retry_threshold: Optional[timedelta]
cancellation_type: temporalio.workflow.ActivityCancellationType
headers: Mapping[str, temporalio.api.common.v1.Payload]
summary: Optional[str]

# The types may be absent
arg_types: Optional[List[Type]]
ret_type: Optional[Type]
Expand Down
10 changes: 6 additions & 4 deletions temporalio/worker/_workflow_instance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1464,6 +1464,7 @@ def workflow_start_local_activity(
local_retry_threshold: Optional[timedelta],
cancellation_type: temporalio.workflow.ActivityCancellationType,
activity_id: Optional[str],
summary: Optional[str],
) -> temporalio.workflow.ActivityHandle[Any]:
# Get activity definition if it's callable
name: str
Expand Down Expand Up @@ -1496,6 +1497,7 @@ def workflow_start_local_activity(
retry_policy=retry_policy,
local_retry_threshold=local_retry_threshold,
cancellation_type=cancellation_type,
summary=summary,
headers={},
arg_types=arg_types,
ret_type=ret_type,
Expand Down Expand Up @@ -2766,6 +2768,10 @@ def _apply_schedule_command(
v.start_to_close_timeout.FromTimedelta(self._input.start_to_close_timeout)
if self._input.retry_policy:
self._input.retry_policy.apply_to_proto(v.retry_policy)
if self._input.summary:
command.user_metadata.summary.CopyFrom(
self._instance._payload_converter.to_payload(self._input.summary)
)
v.cancellation_type = cast(
temporalio.bridge.proto.workflow_commands.ActivityCancellationType.ValueType,
int(self._input.cancellation_type),
Expand All @@ -2787,10 +2793,6 @@ def _apply_schedule_command(
command.schedule_activity.versioning_intent = (
self._input.versioning_intent._to_proto()
)
if self._input.summary:
command.user_metadata.summary.CopyFrom(
self._instance._payload_converter.to_payload(self._input.summary)
)
if self._input.priority:
command.schedule_activity.priority.CopyFrom(
self._input.priority._to_proto()
Expand Down
Loading
Loading