Skip to content

Fix Flaky Test: test_custom_slot_supplier #1117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
Closed

Fix Flaky Test: test_custom_slot_supplier #1117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
d1d90c2
Add debugging
tconley1428 Sep 24, 2025
4949971
Lint
tconley1428 Sep 24, 2025
dcd74d6
Add reserve context
tconley1428 Sep 24, 2025
bf481ed
Merge branch 'main' into test_custom_slot_supplier
tconley1428 Sep 26, 2025
dc07340
Update core
tconley1428 Sep 26, 2025
dde8c32
Core debug
tconley1428 Sep 26, 2025
be9ae04
Update
tconley1428 Sep 26, 2025
1d4862f
Update
tconley1428 Sep 26, 2025
017a227
Update
tconley1428 Sep 29, 2025
5a513fa
Update
tconley1428 Sep 29, 2025
78ea644
Update
tconley1428 Sep 29, 2025
3d95b6c
Update
tconley1428 Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,48 @@ jobs:
- run: poe lint
- run: poe build-develop
- run: mkdir junit-xml
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_custom_slot_supplier" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_custom_slot_supplier" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_custom_slot_supplier" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_custom_slot_supplier" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_custom_slot_supplier" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_custom_slot_supplier" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_custom_slot_supplier" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_custom_slot_supplier" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_custom_slot_supplier" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_custom_slot_supplier" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_custom_slot_supplier" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_custom_slot_supplier" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_custom_slot_supplier" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_custom_slot_supplier" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_custom_slot_supplier" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_custom_slot_supplier" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_custom_slot_supplier" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_custom_slot_supplier" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_custom_slot_supplier" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_custom_slot_supplier" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_custom_slot_supplier" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -s --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 15
# Time skipping doesn't yet support ARM
Expand Down
7 changes: 7 additions & 0 deletions temporalio/bridge/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions temporalio/bridge/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,14 @@ pyo3 = { version = "0.25", features = [
] }
pyo3-async-runtimes = { version = "0.25", features = ["tokio-runtime"] }
pythonize = "0.25"
temporal-client = { version = "0.1.0", path = "./sdk-core/client" }
temporal-sdk-core = { version = "0.1.0", path = "./sdk-core/core", features = [
temporal-client = { git = "https://github.com/temporalio/sdk-core", branch = "debug_slot_supplier" }
temporal-sdk-core = { git = "https://github.com/temporalio/sdk-core", branch = "debug_slot_supplier", features = [
"ephemeral-server",
] }
temporal-sdk-core-api = { version = "0.1.0", path = "./sdk-core/core-api", features = [
temporal-sdk-core-api = { git = "https://github.com/temporalio/sdk-core", branch = "debug_slot_supplier", features = [
"envconfig",
] }
temporal-sdk-core-protos = { version = "0.1.0", path = "./sdk-core/sdk-core-protos" }
temporal-sdk-core-protos = { git = "https://github.com/temporalio/sdk-core", branch = "debug_slot_supplier" }
tokio = "1.26"
tokio-stream = "0.1"
tonic = "0.13"
Expand Down
2 changes: 1 addition & 1 deletion temporalio/bridge/sdk-core
Open in desktop
Submodule sdk-core updated 38 files
+34 −32 client/src/lib.rs
+34 −96 client/src/raw.rs
+253 −0 client/src/replaceable.rs
+9 −6 client/src/retry.rs
+1 −2 client/src/workflow_handle/mod.rs
+31 −11 core-api/src/envconfig.rs
+2 −0 core-c-bridge/Cargo.toml
+61 −0 core-c-bridge/include/temporal-sdk-core-c-bridge.h
+5 −5 core-c-bridge/src/client.rs
+314 −0 core-c-bridge/src/envconfig.rs
+1 −0 core-c-bridge/src/lib.rs
+4 −10 core-c-bridge/src/tests/context.rs
+2 −3 core/src/ephemeral_server/mod.rs
+48 −32 core/src/lib.rs
+6 −4 core/src/protosext/mod.rs
+1 −1 core/src/protosext/protocol_messages.rs
+256 −108 core/src/retry_logic.rs
+1 −2 core/src/telemetry/prometheus_meter.rs
+2 −2 core/src/worker/activities.rs
+18 −18 core/src/worker/activities/local_activities.rs
+51 −39 core/src/worker/client.rs
+1 −1 core/src/worker/client/mocks.rs
+8 −4 core/src/worker/mod.rs
+1 −1 sdk-core-protos/src/history_builder.rs
+13 −3 sdk-core-protos/src/lib.rs
+1 −1 sdk/src/activity_context.rs
+1 −1 sdk/src/app_data.rs
+1 −4 sdk/src/interceptors.rs
+1 −5 sdk/src/lib.rs
+1 −1 sdk/src/workflow_future.rs
+55 −5 tests/common/mod.rs
+4 −4 tests/integ_tests/ephemeral_server_tests.rs
+304 −90 tests/integ_tests/polling_tests.rs
+1 −1 tests/integ_tests/update_tests.rs
+4 −4 tests/integ_tests/worker_versioning_tests.rs
+4 −4 tests/integ_tests/workflow_tests/activities.rs
+1 −1 tests/main.rs
+7 −39 tests/runner.rs
2 changes: 1 addition & 1 deletion temporalio/runtime.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ def _to_bridge_config(self) -> temporalio.bridge.runtime.LoggingConfig:


LoggingConfig.default = LoggingConfig(
filter=TelemetryFilter(core_level="WARN", other_level="ERROR")
filter=TelemetryFilter(core_level="DEBUG", other_level="ERROR")
)

_module_start_time = time.time()
Expand Down
15 changes: 15 additions & 0 deletions tests/worker/test_worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import asyncio
import concurrent.futures
import logging
import uuid
from datetime import timedelta
from typing import Any, Awaitable, Callable, Optional, Sequence
Expand Down Expand Up @@ -64,6 +65,8 @@
with workflow.unsafe.imports_passed_through():
import pytest

logger = logging.getLogger(__name__)


def test_load_default_worker_binary_id():
# Just run it twice and confirm it didn't change
Expand Down Expand Up @@ -469,6 +472,12 @@ async def reserve_slot(self, ctx: SlotReserveContext) -> SlotPermit:
# Verify an async call doesn't bungle things
await asyncio.sleep(0.01)
self.reserves += 1
logger.info(
"Reserve slot %d - %s - %s",
self.reserves,
ctx.slot_type,
ctx.task_queue,
)
return MyPermit(self.reserves)

def try_reserve_slot(self, ctx: SlotReserveContext) -> Optional[SlotPermit]:
Expand All @@ -494,6 +503,12 @@ def release_slot(self, ctx: SlotReleaseContext) -> None:
assert ctx.permit is not None
assert isinstance(ctx.permit, MyPermit)
assert ctx.permit.pnum is not None

logger.info(
"Release slot %d, %d",
ctx.permit.pnum,
self.highest_seen_reserve_on_release,
)
self.highest_seen_reserve_on_release = max(
ctx.permit.pnum, self.highest_seen_reserve_on_release
)
Expand Down
Loading