Skip to content

Fix flaky test: test_update_handler_lock_acquisition_respects_timeout #1118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix flaky test: test_update_handler_lock_acquisition_respects_timeout #1118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,48 @@ jobs:
- run: poe lint
- run: poe build-develop
- run: mkdir junit-xml
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_update_handler_lock_acquisition_respects_timeout" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_update_handler_lock_acquisition_respects_timeout" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_update_handler_lock_acquisition_respects_timeout" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_update_handler_lock_acquisition_respects_timeout" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_update_handler_lock_acquisition_respects_timeout" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_update_handler_lock_acquisition_respects_timeout" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_update_handler_lock_acquisition_respects_timeout" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_update_handler_lock_acquisition_respects_timeout" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_update_handler_lock_acquisition_respects_timeout" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_update_handler_lock_acquisition_respects_timeout" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_update_handler_lock_acquisition_respects_timeout" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_update_handler_lock_acquisition_respects_timeout" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_update_handler_lock_acquisition_respects_timeout" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_update_handler_lock_acquisition_respects_timeout" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_update_handler_lock_acquisition_respects_timeout" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_update_handler_lock_acquisition_respects_timeout" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_update_handler_lock_acquisition_respects_timeout" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_update_handler_lock_acquisition_respects_timeout" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_update_handler_lock_acquisition_respects_timeout" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_update_handler_lock_acquisition_respects_timeout" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_update_handler_lock_acquisition_respects_timeout" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -s --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 15
# Time skipping doesn't yet support ARM
Expand Down
3 changes: 3 additions & 0 deletions temporalio/service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1361,6 +1361,9 @@ async def _rpc_call(
logger.debug("Service %s response from %s: %s", service, rpc, resp)
return resp
except temporalio.bridge.client.RPCError as err:
logger.info(
"Service %s failed to call %s: %s", service, rpc, err, exc_info=True
)
# Intentionally swallowing the cause instead of using "from"
status, message, details = err.args
raise RPCError(message, RPCStatusCode(status), details)
Expand Down
4 changes: 4 additions & 0 deletions tests/helpers/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import asyncio
import logging
import socket
import time
import uuid
Expand Down Expand Up @@ -32,6 +33,8 @@
UpdateMethodMultiParam,
)

logger = logging.getLogger(__name__)


def new_worker(
client: Client,
Expand Down Expand Up @@ -153,6 +156,7 @@ async def workflow_update_exists(
client: Client, workflow_id: str, update_id: str
) -> bool:
try:
logger.info("Checking workflow update status: %s", update_id)
await client.workflow_service.poll_workflow_execution_update(
PollWorkflowExecutionUpdateRequest(
namespace=client.namespace,
Expand Down
Loading