pytest and pydoctor QOL improvements #1124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdk-python(dan-9986-serialization-context અ ) poe gen-docs Poe => uv run scripts/gen_docs.py Generating documentation... /Users/dan/src/temporal/repos/sdk-python/temporalio/activity.py:291: Cannot find link target for "async def" /Users/dan/src/temporal/repos/sdk-python/temporalio/client.py:7538: ambiguous ref to connect, could be temporalio.client.Client.connect, temporalio.client.CloudOperationsClient.connect /Users/dan/src/temporal/repos/sdk-python/temporalio/client.py:7538: Cannot find link target for "connect" /Users/dan/src/temporal/repos/sdk-python/temporalio/client.py:7538: ambiguous ref to connect, could be temporalio.client.Client.connect, temporalio.client.CloudOperationsClient.connect /Users/dan/src/temporal/repos/sdk-python/temporalio/client.py:7538: Cannot find link target for "connect" /Users/dan/src/temporal/repos/sdk-python/temporalio/contrib/openai_agents/workflow.py:63: Documented parameter "For other arguments" does not exist /Users/dan/src/temporal/repos/sdk-python/temporalio/contrib/openai_agents/workflow.py:64: Documented parameter "refer to workflow start_activity" does not exist /Users/dan/src/temporal/repos/sdk-python/temporalio/contrib/openai_agents/workflow.py:176: Documented parameter "fn" does not exist /Users/dan/src/temporal/repos/sdk-python/temporalio/envconfig.py:187: Cannot find link target for "to_connect_config" /Users/dan/src/temporal/repos/sdk-python/temporalio/envconfig.py:307: Cannot find link target for "temporalio.envconfig.ClientConfigProfile.to_connect_config", resolved from "ClientConfigProfile.to_connect_config" /Users/dan/src/temporal/repos/sdk-python/temporalio/envconfig.py:308: Cannot find link target for "load_profile" /Users/dan/src/temporal/repos/sdk-python/temporalio/nexus/_operation_handlers.py:112: Documented parameter "to pass to the workflow cancel method." does not exist, variable keywords should be documented with the "Keyword Arguments" section /Users/dan/src/temporal/repos/sdk-python/temporalio/nexus/_util.py:128: Cannot find link target for "Operation" /Users/dan/src/temporal/repos/sdk-python/temporalio/nexus/_util.py:42: Cannot find link target for "start" /Users/dan/src/temporal/repos/sdk-python/temporalio/nexus/_util.py:161: Cannot find link target for "obj" /Users/dan/src/temporal/repos/sdk-python/temporalio/nexus/_util.py:148: Cannot find link target for "OperationHandler" /Users/dan/src/temporal/repos/sdk-python/temporalio/worker/_workflow.py:620: Cannot find link target for "message" /Users/dan/src/temporal/repos/sdk-python/temporalio/worker/_workflow.py:620: Cannot find link target for "replacement_tb" /Users/dan/src/temporal/repos/sdk-python/temporalio/worker/workflow_sandbox/_importer.py:307: Cannot find link target for "_Environment.maybe_restrict_module" (you can link to external docs with --intersphinx) /Users/dan/src/temporal/repos/sdk-python/temporalio/worker/_interceptor.py:471: Cannot find link target for "temporalio.workflow.start_nexus_operation" /Users/dan/src/temporal/repos/sdk-python/temporalio/worker/_tuning.py:77: Cannot find link target for "CompositeTuner" /Users/dan/src/temporal/repos/sdk-python/temporalio/worker/_tuning.py:30: Cannot find link target for "ResourceBasedTuner" /Users/dan/src/temporal/repos/sdk-python/temporalio/worker/_worker.py:164: Cannot find link target for "@nexusrpc.handler.service_handler" (you can link to external docs with --intersphinx) /Users/dan/src/temporal/repos/sdk-python/temporalio/worker/_worker.py:189: Cannot find link target for "async def" /Users/dan/src/temporal/repos/sdk-python/temporalio/worker/_worker.py:300: ambiguous ref to build_id, could be temporalio.worker.ReplayerConfig.build_id, temporalio.worker.WorkerConfig.build_id, temporalio.worker.WorkerDeploymentVersion.build_id /Users/dan/src/temporal/repos/sdk-python/temporalio/worker/_worker.py:300: Cannot find link target for "build_id" /Users/dan/src/temporal/repos/sdk-python/temporalio/worker/_worker.py:315: ambiguous ref to build_id, could be temporalio.worker.ReplayerConfig.build_id, temporalio.worker.WorkerConfig.build_id, temporalio.worker.WorkerDeploymentVersion.build_id /Users/dan/src/temporal/repos/sdk-python/temporalio/worker/_worker.py:315: Cannot find link target for "build_id" /Users/dan/src/temporal/repos/sdk-python/temporalio/worker/_worker.py:316: ambiguous ref to use_worker_versioning, could be temporalio.worker.WorkerConfig.use_worker_versioning, temporalio.worker.WorkerDeploymentConfig.use_worker_versioning /Users/dan/src/temporal/repos/sdk-python/temporalio/worker/_worker.py:316: Cannot find link target for "use_worker_versioning" /Users/dan/src/temporal/repos/sdk-python/temporalio/common.py:1091: Cannot find link target for "." (you can link to external docs with --intersphinx) /Users/dan/src/temporal/repos/sdk-python/temporalio/worker/_workflow_instance.py:180: Documented parameter "codec will have serialization context set appropriately for that command." does not exist /Users/dan/src/temporal/repos/sdk-python/temporalio/workflow.py:4301: Cannot find link target for "Workflow.get_current_details" (you can link to external docs with --intersphinx) /Users/dan/src/temporal/repos/sdk-python/temporalio/workflow.py:5247: Cannot find link target for "await"
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
|
||
| def pytest_runtest_setup(item): | ||
| """Print a newline so that custom printed output starts on new line.""" | ||
| if item.config.getoption("-s"): |
There was a problem hiding this comment.
Bug: Pytest Capture Status Detection Flaw
The pytest_runtest_setup hook's check for item.config.getoption("-s") doesn't reliably detect when pytest's output capturing is disabled. The -s flag is a shorthand for --capture=no, so checking for it directly may not accurately reflect the capture status.
Contributor
Author
There was a problem hiding this comment.
I checked that; it does.
chris-olszewski
approved these changes
Sep 29, 2025
tconley1428
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--capture=nois active. This means that any printed output you create during debugging will start on a new line.pydoctor --quiet. This causes us to see errors/warnings but not see hundreds of "moving..." lines telling us about files it is moving.Note
Run
pydoctor --quietin docs generator and print a newline before test output when-sis used in pytest.scripts/gen_docs.pyby runningpydoctor --quiet.pytest_runtest_setupto print a leading newline for test output when-sis enabled intests/conftest.py.Written by Cursor Bugbot for commit 1083300. This will update automatically on new commits. Configure here.