Skip to content

pytest and pydoctor QOL improvements #1124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 29, 2025
Merged

pytest and pydoctor QOL improvements #1124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d841d9
pytest qol
dandavison Sep 26, 2025
1083300
pydoctor --quiet
dandavison Sep 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/gen_docs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
print("Generating documentation...")

# Run pydoctor
subprocess.check_call("pydoctor")
subprocess.check_call(["pydoctor", "--quiet"])

# Copy favicon
shutil.copyfile(
Expand Down
6 changes: 6 additions & 0 deletions tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,12 @@
from tests.helpers.worker import ExternalPythonWorker, ExternalWorker


def pytest_runtest_setup(item):
"""Print a newline so that custom printed output starts on new line."""
if item.config.getoption("-s"):
Copy link

@cursor cursor bot Sep 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Pytest Capture Status Detection Flaw

The pytest_runtest_setup hook's check for item.config.getoption("-s") doesn't reliably detect when pytest's output capturing is disabled. The -s flag is a shorthand for --capture=no, so checking for it directly may not accurately reflect the capture status.

Fix in Cursor Fix in Web

Copy link
Contributor Author

@dandavison dandavison Sep 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked that; it does.

print()


def pytest_addoption(parser):
parser.addoption(
"-E",
Expand Down
Loading