Skip to content

Fix Flaky Test: test_custom_slot_supplier #1126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 29, 2025
Merged

Fix Flaky Test: test_custom_slot_supplier #1126

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
30af195
Remove slot assert
tconley1428 Sep 29, 2025
0611905
Assert <=
tconley1428 Sep 29, 2025
155f260
>=
tconley1428 Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/worker/test_worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,7 +540,7 @@ def reserve_asserts(self, ctx: SlotReserveContext) -> None:
# where the python reserve function appears to complete, but Rust doesn't see that.
# This isn't solvable without redoing a chunk of pyo3-asyncio. So we only check
# that the permits passed to release line up.
assert ss.highest_seen_reserve_on_release == ss.releases
assert ss.highest_seen_reserve_on_release >= ss.releases
assert ss.used == 5
assert ss.seen_sticky_kinds == {True, False}
assert ss.seen_slot_kinds == {"workflow", "activity", "local-activity", "nexus"}
Expand Down