Skip to content

Debugging flaky session test #1127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Debugging flaky session test #1127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,48 @@ jobs:
- run: poe lint
- run: poe build-develop
- run: mkdir junit-xml
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_session" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_session" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_session" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_session" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_session" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_session" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_session" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_session" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_session" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_session" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_session" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_session" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_session" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_session" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_session" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_session" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_session" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_session" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_session" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_session" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -k "test_session" -sv --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 5
- run: poe test ${{matrix.pytestExtraArgs}} -s --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
timeout-minutes: 15
# Time skipping doesn't yet support ARM
Expand Down
17 changes: 11 additions & 6 deletions tests/helpers/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,13 +92,18 @@ async def assert_task_fail_eventually(
handle: WorkflowHandle, *, message_contains: Optional[str] = None
) -> None:
async def check() -> None:
task_failed = None
async for evt in handle.fetch_history_events():
if evt.HasField("workflow_task_failed_event_attributes") and (
not message_contains
or message_contains
in evt.workflow_task_failed_event_attributes.failure.message
):
return
if evt.HasField("workflow_task_failed_event_attributes"):
task_failed = evt
if (
not message_contains
or message_contains
in evt.workflow_task_failed_event_attributes.failure.message
):
return
if task_failed:
assert False, f"Task failure not correct: {task_failed.workflow_task_failed_event_attributes.failure.message}"
assert False, "Task failure not present"

await assert_eventually(check)
Expand Down
Loading