Skip to content

Use type in start/execute activity/workflow to address Pyright Strict mode error #1137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 2, 2025
Merged

Use type in start/execute activity/workflow to address Pyright Strict mode error #1137

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4ec4889
Add explict any instead of a type that resolves to Unknown in pryight…
VegetarianOrc Sep 26, 2025
e15d4c4
Use explicit Any on start/execute Workflow
VegetarianOrc Sep 30, 2025
f7e03d6
Use 'type' rather than 'Any' to better maintain original intent while…
VegetarianOrc Oct 1, 2025
e73b09c
Swap from 'Any' to 'type' where missed in previous commit
VegetarianOrc Oct 2, 2025
bfbd8b9
Merge branch 'main' into bug/fix-pyright-partial-unknown
VegetarianOrc Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions temporalio/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,7 +456,7 @@ async def start_workflow(
args: Sequence[Any] = [],
id: str,
task_queue: str,
result_type: Optional[Type] = None,
result_type: Optional[type] = None,
execution_timeout: Optional[timedelta] = None,
run_timeout: Optional[timedelta] = None,
task_timeout: Optional[timedelta] = None,
Expand Down Expand Up @@ -491,7 +491,7 @@ async def start_workflow(
args: Sequence[Any] = [],
id: str,
task_queue: str,
result_type: Optional[Type] = None,
result_type: Optional[type] = None,
execution_timeout: Optional[timedelta] = None,
run_timeout: Optional[timedelta] = None,
task_timeout: Optional[timedelta] = None,
Expand Down Expand Up @@ -737,7 +737,7 @@ async def execute_workflow(
args: Sequence[Any] = [],
id: str,
task_queue: str,
result_type: Optional[Type] = None,
result_type: Optional[Any] = None,
Copy link
Member

@cretz cretz Oct 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this one (and the concrete impl's signature) be left as type too instead of changing to Any?

Copy link
Contributor Author

@VegetarianOrc VegetarianOrc Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely, not sure how I missed those the first go around 😅

execution_timeout: Optional[timedelta] = None,
run_timeout: Optional[timedelta] = None,
task_timeout: Optional[timedelta] = None,
Expand Down Expand Up @@ -772,7 +772,7 @@ async def execute_workflow(
args: Sequence[Any] = [],
id: str,
task_queue: str,
result_type: Optional[Type] = None,
result_type: Optional[Any] = None,
execution_timeout: Optional[timedelta] = None,
run_timeout: Optional[timedelta] = None,
task_timeout: Optional[timedelta] = None,
Expand Down
8 changes: 4 additions & 4 deletions temporalio/workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2210,7 +2210,7 @@ def start_activity(
*,
args: Sequence[Any] = [],
task_queue: Optional[str] = None,
result_type: Optional[Type] = None,
result_type: Optional[type] = None,
schedule_to_close_timeout: Optional[timedelta] = None,
schedule_to_start_timeout: Optional[timedelta] = None,
start_to_close_timeout: Optional[timedelta] = None,
Expand All @@ -2230,7 +2230,7 @@ def start_activity(
*,
args: Sequence[Any] = [],
task_queue: Optional[str] = None,
result_type: Optional[Type] = None,
result_type: Optional[type] = None,
schedule_to_close_timeout: Optional[timedelta] = None,
schedule_to_start_timeout: Optional[timedelta] = None,
start_to_close_timeout: Optional[timedelta] = None,
Expand Down Expand Up @@ -2426,7 +2426,7 @@ async def execute_activity(
*,
args: Sequence[Any] = [],
task_queue: Optional[str] = None,
result_type: Optional[Type] = None,
result_type: Optional[Any] = None,
schedule_to_close_timeout: Optional[timedelta] = None,
schedule_to_start_timeout: Optional[timedelta] = None,
start_to_close_timeout: Optional[timedelta] = None,
Expand All @@ -2446,7 +2446,7 @@ async def execute_activity(
*,
args: Sequence[Any] = [],
task_queue: Optional[str] = None,
result_type: Optional[Type] = None,
result_type: Optional[Any] = None,
schedule_to_close_timeout: Optional[timedelta] = None,
schedule_to_start_timeout: Optional[timedelta] = None,
start_to_close_timeout: Optional[timedelta] = None,
Expand Down
Loading