Avoid token detaching from different context #1153
Open
+209
−103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…was used to attach it
…helpers to test/helpers
cretz
reviewed
Oct 17, 2025
…ot just equal but is the same object
cretz
approved these changes
Oct 17, 2025
| # different contextvars.Context than the one the token was created | ||
| # on. As such we do a best effort detach to avoid using a mismatched | ||
| # token. | ||
| if context is opentelemetry.context.get_current(): |
tests/worker/test_workflow.py
Outdated
| unpause_and_assert, | ||
| workflow_update_exists, | ||
| ) | ||
| from tests.helpers.cache_evitction import ( |
tconley1428
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
The OpenTelemetry and OpenAI Agents interceptors have been updated to avoid detaching context in such a way that does not cause a
<Token> was created in a different Contexterror.Why?
There are some situations where cleanup happens in a different
asyncio.Task(when tasks get garbage collected for instance). When those situations happen thecontextvars.Contextused to create thecontextvars.Tokenis no longer available. By confirming that the Otel context is the same as the one we attached, we can do a best effort detach and avoid the error.Checklist
Issues Closed
How was this tested:
A new test was added to force a GeneratorExit error after a task is garbage collected by disabling safe eviction. The test captures OpenTelemetry logs and ensures that the
Failed to detach contextmessage is not printed.