Send plugin names to Core #1157
Conversation
…untime client identity requirement
| self, | ||
| *, | ||
| telemetry: Optional[TelemetryConfig] = None, | ||
| runtime_options: Optional["RuntimeOptions"] = None, |
There was a problem hiding this comment.
I think you should either inline runtime options into kwargs here, or have user-facing runtime options not include telemetry. To have telemetry in both places is confusing.
There was a problem hiding this comment.
I think I would just take the two components here and then build the runtime options. Only because of the backwards compatibility.
|
|
||
| // Create core runtime which starts tokio multi-thread runtime | ||
| let mut core = CoreRuntime::new( | ||
| let mut runtime_options_build = RuntimeOptionsBuilder::default(); |
There was a problem hiding this comment.
I think it would be ideal for the variable to be immutable and do the builder args in a chain.
RuntimeOptionsBuilder::default().telemetry_options(...).heartbeat_interal(ms.map(Duration::from_millis))Or something
| activity_task_poller_behavior: PollerBehavior | ||
| nexus_task_poller_behavior: PollerBehavior | ||
| plugins: Sequence[Plugin] | ||
| skip_client_worker_set_check: bool |
There was a problem hiding this comment.
I don't love the addition of this to the very public worker config. This was due to validation issues in the tests, correct? How much work do we think it would be to actually just fix those issues? Is there any place where it is really meaningful?
| ) | ||
| .nexus_task_poller_behavior(conf.nexus_task_poller_behavior) | ||
| .plugins( | ||
| conf.plugins |
There was a problem hiding this comment.
So, something that will need some discussion here. This PR reports worker plugins. We should discuss whether that is really what we intend. Plugins which exist only in the client and not the worker will be completely invisible. That could potentially be changed here at least for plugins in clients used by workers, though not generally for any client. I think that was something we didn't really think through when we decided to go with heartbeat as a carrier for this information, but maybe we conclude that is fine.
Typescript will be a bit more complicated as well with its additional plugin types.
| """Python representation of the Rust struct for runtime options.""" | ||
|
|
||
| telemetry: TelemetryConfig | ||
| worker_heartbeat_interval_millis: Optional[int] = 30_000 # 30s |
There was a problem hiding this comment.
Do we want the defaults defined by each language, or does this make more sense to take optionally into core and default there? Since this is optional but with a default number, does that mean overriding with None disables heartbeating?
| 1 | ||
| ), | ||
| plugins=[plugin.name() for plugin in self.plugins], | ||
| skip_client_worker_set_check=True, |
There was a problem hiding this comment.
Is this important? Will the replayer break if this is False?
| self, | ||
| *, | ||
| telemetry: Optional[TelemetryConfig] = None, | ||
| runtime_options: Optional["RuntimeOptions"] = None, |
There was a problem hiding this comment.
I would probably just move the type definition up so you don't have to do the "Type" thing.
|
|
||
|
|
||
| @pytest.fixture(autouse=True) | ||
| def _force_worker_skip_client_set(monkeypatch): |
There was a problem hiding this comment.
Not really a force if we are just setting the default.
3 participants
What was changed
Send plugin names over to core for worker heartbeating.
Updated Core to latest main, 9e9a461.
Updated test to validate replacing clients with a client from a different runtime is invalid.
Why?
Worker heartbeating
Checklist
Closes
How was this tested:
Added tests for plugin name propogation, and runtime options configuration
Note
Forward plugin names to Core for worker heartbeating, introduce runtime options (incl worker heartbeat), tighten client replacement to same-runtime, and bump Core/deps (prost/tonic/OTel).
WorkerConfig.plugins(mapped toPluginInfo); addskip_client_worker_set_checkflag; propagate plugins from client to worker; tests validate propagation and Core forwarding.replace_clientnow returns error on failure; PythonWorker.clientsetter enforces same-runtime clients.RuntimeOptions(Python/Rust) and changeinit_runtimeto acceptoptions; supportworker_heartbeat_interval/heartbeat_intervalwiring; tests for conversion/validation.TemporalServiceClient(drop metrics wrapper); adjust tonic imports.prost/tonic/opentelemetry*; addtonic-prost*,dyn-clone; bumpuuid; updatesdk-coresubmodule.skip_client_worker_set_check; cleanups.Written by Cursor Bugbot for commit efb91e4. This will update automatically on new commits. Configure here.